Skip to content

Commit 8b0ef15

Browse files
committed
fixing unit tests and swtiching coords to graphicData
1 parent 8af8a94 commit 8b0ef15

File tree

3 files changed

+15
-12
lines changed

3 files changed

+15
-12
lines changed

src/api.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ function _scoord3d2Geometry(scoord3d, pyramid) {
8888
});
8989
return new PolygonGeometry([coordinates]);
9090
} else if (type === 'CIRCLE') {
91-
let center = _scoord3dCoordinates2geometryCoordinates(scoord3d.centerCoordinates, pyramid);
92-
let radius = scoord3d.radius;
91+
let center = _scoord3dCoordinates2geometryCoordinates(data[0], pyramid);
92+
let radius = data[1];
9393
return new CircleGeometry(center, radius);
9494
} else {
9595
console.error(`unsupported graphic type "${type}"`)

src/scoord3d.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ class Circle extends Scoord3D {
158158
*/
159159
return [
160160
this[_centerCoordinates],
161-
[this[_centerCoordinates[0]], this[_centerCoordinates[1]] + this[_radius], 1]]
161+
[this[_centerCoordinates][0], this[_centerCoordinates][1] + this[_radius], 1]]
162162
}
163163

164164
get graphicType() {

test/api.spec.js

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,43 +77,46 @@ describe('dicomMicroscopyViewer.api.VLWholeSlideMicroscopyImageViewer', ()=> {
7777
it('should create a Circle ROI and return it back successfuly', () => {
7878
const roi = new dicomMicroscopyViewer.roi.ROI({scoord3d : circle, properties});
7979
viewer.addROI(roi);
80-
assert.deepEqual(viewer.getROI(0).scoord3d.coordinates, circle.coordinates);
80+
console.log('####')
81+
console.log(viewer.getROI(0).scoord3d.graphicData[0])
82+
console.log('####')
83+
assert.deepEqual(viewer.getROI(0).scoord3d.graphicData[0], circle.graphicData[0]);
8184
})
8285

8386
it('should create a Point ROI and return it back successfuly', () => {
8487
const roi = new dicomMicroscopyViewer.roi.ROI({scoord3d : point, properties});
8588
viewer.addROI(roi);
86-
assert.deepEqual(viewer.getROI(1).scoord3d.coordinates, point.coordinates);
89+
assert.deepEqual(viewer.getROI(1).scoord3d.graphicData, point.graphicData);
8790
})
8891

8992
it('should create a Box ROI and return it back successfuly', () => {
9093
const roi = new dicomMicroscopyViewer.roi.ROI({scoord3d : box, properties});
9194
viewer.addROI(roi);
92-
assert.deepEqual(viewer.getROI(2).scoord3d.coordinates, box.coordinates);
95+
assert.deepEqual(viewer.getROI(2).scoord3d.graphicData, box.graphicData);
9396
})
9497

9598
it('should create a Polygon ROI and return it back successfuly', () => {
9699
const roi = new dicomMicroscopyViewer.roi.ROI({scoord3d : polygon, properties});
97100
viewer.addROI(roi);
98-
assert.deepEqual(viewer.getROI(3).scoord3d.coordinates, polygon.coordinates);
101+
assert.deepEqual(viewer.getROI(3).scoord3d.graphicData, polygon.graphicData);
99102
})
100103

101104
it('should create a Freehand Polygon ROI and return it back successfuly', () => {
102105
const roi = new dicomMicroscopyViewer.roi.ROI({scoord3d : freehandPolygon, properties});
103106
viewer.addROI(roi);
104-
assert.deepEqual(viewer.getROI(4).scoord3d.coordinates, freehandPolygon.coordinates);
107+
assert.deepEqual(viewer.getROI(4).scoord3d.graphicData, freehandPolygon.graphicData);
105108
})
106109

107110
it('should create a Line ROI and return it back successfuly', () => {
108111
const roi = new dicomMicroscopyViewer.roi.ROI({scoord3d : line, properties});
109112
viewer.addROI(roi);
110-
assert.deepEqual(viewer.getROI(5).scoord3d.coordinates, line.coordinates);
113+
assert.deepEqual(viewer.getROI(5).scoord3d.graphicData, line.graphicData);
111114
})
112115

113116
it('should create a FreehandLine ROI and return it back successfuly', () => {
114117
const roi = new dicomMicroscopyViewer.roi.ROI({scoord3d : freeHandLine, properties});
115118
viewer.addROI(roi);
116-
assert.deepEqual(viewer.getROI(6).scoord3d.coordinates, freeHandLine.coordinates);
119+
assert.deepEqual(viewer.getROI(6).scoord3d.graphicData, freeHandLine.graphicData);
117120
})
118121

119122
it('should return all ROIs created up to now', () => {
@@ -124,11 +127,11 @@ describe('dicomMicroscopyViewer.api.VLWholeSlideMicroscopyImageViewer', ()=> {
124127
it('should be able to remove the circle ROI', () => {
125128
let rois = viewer.getAllROIs();
126129
assert.equal(rois.length, 7);
127-
assert.deepEqual(viewer.getROI(0).scoord3d.coordinates, circle.coordinates);
130+
assert.deepEqual(viewer.getROI(0).scoord3d.graphicData[0], circle.graphicData[0]);
128131
viewer.removeROI(0);
129132
rois = viewer.getAllROIs();
130133
assert.equal(rois.length, 6);
131-
assert.deepEqual(viewer.getROI(0).scoord3d.coordinates, point.coordinates);
134+
assert.deepEqual(viewer.getROI(0).scoord3d.graphicData, point.graphicData);
132135
})
133136

134137
it('should be able to modify the point ROI', () => {

0 commit comments

Comments
 (0)