-
Notifications
You must be signed in to change notification settings - Fork 41
CI: Pin GitHub actions to full length commit SHA #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Pin GitHub actions to full length commit SHA #121
Conversation
GitHub's security hardening guide recommends this mitigation method. https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
|
CPBridge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
@CPBridge Are you able to trigger the run_unit_tests.yml workflow with this PR? That's what I was hoping to see here in terms of whether the CI tests are passing for latest |
|
I was unable to approve the workflow since I only have Triage access on this repo. Only maintainers could approve the full workflow. |
|
@jamesobutler yes it ran and passed, you can see the results (green tick) on the main page of the repo now: https://github.com/ImagingDataCommons/dicomweb-client/ |
|
@CPBridge @jamesobutler the python tests didn't seem to run. Is this a regression?
|
|
Compare that with #122
|
|
@fedorov I think this PR may have been integrated without approving the unit tests workflows to run (since I don't have maintainer role). Integration would have been allowed because the unit tests aren't listed as required status checks for integration into the |
now you do! ;-) |





GitHub's security hardening guide recommends this mitigation method. https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
This was originally warned by SonarQubeCloud at https://github.com/ImagingDataCommons/dicomweb-client/runs/55258424344 as part of my PR #120.
I have issued this PR to pull out this individual commit to see if the unit tests can pass currently as this CI commit wouldn't actually impact the unit tests. This would be most similar to triggering
run_unit_tests.ymlfrom a workflow dispatch for latest commit on the master branch.