Skip to content

Conversation

@jamesobutler
Copy link
Collaborator

GitHub's security hardening guide recommends this mitigation method. https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

This was originally warned by SonarQubeCloud at https://github.com/ImagingDataCommons/dicomweb-client/runs/55258424344 as part of my PR #120.

I have issued this PR to pull out this individual commit to see if the unit tests can pass currently as this CI commit wouldn't actually impact the unit tests. This would be most similar to triggering run_unit_tests.yml from a workflow dispatch for latest commit on the master branch.

@sonarqubecloud
Copy link

@jamesobutler jamesobutler requested a review from fedorov November 13, 2025 13:44
@CPBridge CPBridge self-requested a review November 13, 2025 14:07
Copy link
Collaborator

@CPBridge CPBridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@CPBridge CPBridge merged commit c4f5494 into ImagingDataCommons:master Nov 13, 2025
2 checks passed
@jamesobutler
Copy link
Collaborator Author

@CPBridge Are you able to trigger the run_unit_tests.yml workflow with this PR? That's what I was hoping to see here in terms of whether the CI tests are passing for latest master.

@jamesobutler
Copy link
Collaborator Author

I was unable to approve the workflow since I only have Triage access on this repo. Only maintainers could approve the full workflow.

@CPBridge
Copy link
Collaborator

@jamesobutler yes it ran and passed, you can see the results (green tick) on the main page of the repo now: https://github.com/ImagingDataCommons/dicomweb-client/

@fedorov
Copy link
Member

fedorov commented Nov 13, 2025

@CPBridge @jamesobutler the python tests didn't seem to run. Is this a regression?

image

@fedorov
Copy link
Member

fedorov commented Nov 13, 2025

Compare that with #122

image

@jamesobutler
Copy link
Collaborator Author

@fedorov I think this PR may have been integrated without approving the unit tests workflows to run (since I don't have maintainer role). Integration would have been allowed because the unit tests aren't listed as required status checks for integration into the master branch. You could technically integrate a PR with failing CI due to lack of branch protection rules.

@jamesobutler jamesobutler deleted the pin-github-actions branch November 13, 2025 14:34
@fedorov
Copy link
Member

fedorov commented Nov 13, 2025

since I don't have maintainer role

now you do! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants