Change to definition of SR evidence #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
@CPBridge why not try to fix it in pydicom? And on that note, do you know if pydicom is taking those from here: https://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_O.html ? Since in that table most of the items have the unwanted qualifiers ... |
Collaborator
Author
|
Yes I plan to, but that will be a bigger undertaking and pydicom has a much slower release cycle than highdicom. So this is a quick fix for the short term. There are other issues with pydicom's code, including some errors in the UCUM codes that I found a few weeks ago. I'm not that familiar with how they generate the code tables and would have to look into it, but I suspect you might be right about that table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issues related to SR from @deepakri201 's conversion project:
pydicom.sr.coding.codes.SCT.Sourcewith a manual code to remove the unwanted "(attribute)" part of the meaning string. Also fix some outdated codes found in doc pageshighdicom.sr.utils.collect_evidencefunction in regard to how it determines which evidence goes in the CurrentRequestProcedureEvidenceSequence and which into the PertinentOtherEvidenceSequence. Previously this was based on whether the item is found in the SR content tree. Now it is based on whether the item belongs to the same study as the new SR document.