Skip to content

Increase tolerance used to determine a matrix is orthogonal #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CPBridge merged 2 commits into from
Nov 28, 2025
Merged

Increase tolerance used to determine a matrix is orthogonal #382

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77f506c
Increase tolerance used to determine a matrix is orthogonal
CPBridge Nov 28, 2025
481e466
Spell fix
CPBridge Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/highdicom/spatial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
"""Default tolerance on the dot product to determine perpendicularity."""


_DEFAULT_ORTHOGONAL_TOLERANCE = 1e-4
"""Default tolerance on the matrix elements to determine orthogonality."""


PATIENT_ORIENTATION_OPPOSITES = {
PatientOrientationValuesBiped.L: PatientOrientationValuesBiped.R,
PatientOrientationValuesBiped.R: PatientOrientationValuesBiped.L,
Expand Down Expand Up @@ -957,7 +961,7 @@ def get_closest_patient_orientation(affine: np.ndarray) -> tuple[
def _is_matrix_orthogonal(
m: np.ndarray,
require_unit: bool = True,
tol: float = _DEFAULT_EQUALITY_TOLERANCE,
tol: float = _DEFAULT_ORTHOGONAL_TOLERANCE,
) -> bool:
"""Check whether a matrix is orthogonal.

Expand Down