-
Notifications
You must be signed in to change notification settings - Fork 666
v 4.10.0: Multiple PRs merged #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8d11c1b
7965ce2
4aaad16
a61e94e
e4133b7
0919f70
c9980c2
dc951bf
11aa9a3
842fd02
f4d97f5
014cd2d
0de31b9
be3f371
2c6afa7
31492dc
4ede715
8e89387
9f8a941
871f277
15aff92
9b05321
498c3c1
7926983
6023f8d
8ca23c3
2c6db66
2a415e8
792931d
9aa9729
ccafa56
f7c0f03
adcadc9
dfa723e
6ddf690
bd71866
1b2b0ee
9d2dea4
8e3b0ef
fe2038f
d5f22aa
b7eca91
88a34cc
f6ac703
72108de
4c3562c
e974b01
0abaf32
43b6a84
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,14 @@ | ||
| { | ||
| "name": "nuklear", | ||
| "version": "4.09.0", | ||
| "version": "4.10.0", | ||
| "repo": "Immediate-Mode-UI/Nuklear", | ||
| "description": "A small ANSI C gui toolkit", | ||
| "keywords": ["gl", "ui", "toolkit"], | ||
| "src": ["nuklear.h"] | ||
| "keywords": [ | ||
| "gl", | ||
| "ui", | ||
| "toolkit" | ||
| ], | ||
| "src": [ | ||
| "nuklear.h" | ||
| ] | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's not change the formatting of the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason? To me it seems easier to read this way
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm indifferent here. But generally speaking if such changes shall further extend big PRs I'd beg everyone to leave them out for the sake of clarity.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would personally also like it to be formatted this way, as then it would be inline with my json formatter (4 spaces would be nice too). If enough people agree, then sure we can change it, but I don't want to end up en a situation where we change the clib.json format in every PR, if you know what I mean :) |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <meta charset='utf-8' emacsmode='-*- markdown -*-'> | ||
| <meta charset='utf-8' emacsmode='-*- markdown -*-'> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What changed on this line?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unsure, hopefully not line endings |
||
| <link rel='stylesheet' href='https://casual-effects.com/markdeep/latest/apidoc.css?'> | ||
| <title>Nuklear</title> <!--Page Title--> | ||
| # Nuklear | ||
|
|
@@ -137,6 +137,7 @@ | |
| NK_COS | You can define this to 'cosf' or your own cosine implementation replacement. If not nuklear will use its own approximation implementation. | ||
| NK_STRTOD | You can define this to `strtod` or your own string to double conversion implementation replacement. If not defined nuklear will use its own imprecise and possibly unsafe version (does not handle nan or infinity!). | ||
| NK_DTOA | You can define this to `dtoa` or your own double to string conversion implementation replacement. If not defined nuklear will use its own imprecise and possibly unsafe version (does not handle nan or infinity!). | ||
| NK_ERROR | Defined to NK_ASSERT(0 && ...), when an assert always returns false. This is done to allow strict C++17 implementations to keep on working. | ||
| NK_VSNPRINTF| If you define `NK_INCLUDE_STANDARD_VARARGS` as well as `NK_INCLUDE_STANDARD_IO` and want to be safe define this to `vsnprintf` on compilers supporting later versions of C or C++. By default nuklear will check for your stdlib version in C as well as compiler version in C++. if `vsnprintf` is available it will define it to `vsnprintf` directly. If not defined and if you have older versions of C or C++ it will be defined to `vsprintf` which is unsafe. | ||
| !!! WARNING | ||
| The following dependencies will pull in the standard C library if not redefined: | ||
|
|
@@ -2313,6 +2314,17 @@ | |
| - [x]: Major version with API and library breaking changes | ||
| - [yy]: Minor version with non-breaking API and library changes | ||
| - [zz]: Bug fix version with no direct changes to API | ||
| - 2020/07/06 (4.04.0) - Added subpixel API from itsuhane. Allowing you to turn on | ||
| NK_ENABLE_SUBPIXEL_API to position window and elements in subpixels | ||
| Changed nk_begin to return a nk_window so you can get the position and other useful info. | ||
| Fixed radio buttons' style. | ||
| Fixed click cascading through multiple buttons; it should only click the upper button. | ||
| Strict c++17 now compiles: only declaring memset, memcpy if they are used. | ||
| Only asserting index range if ushorts are used for indices. | ||
| Made paq.sh identical to paq.bat (outputs to nuklear.h). | ||
| Replaced NK_ASSERT(0 && ...) with NK_ERROR(), to ensure it compiles on strict C++17. | ||
| Replaced const char** by const char * const * in combobox, to ensure const List<const char*> can be used. | ||
| Added nk_tree_type for allowing the symbol next to a tree element to be hidden (for children) if it's not an image. | ||
| - 2020/04/09 (4.02.1) - Removed unused nk_sqrt function to fix compiler warnings | ||
| - Fixed compiler warnings if you bring your own methods for | ||
|
Comment on lines
+2317
to
2329
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm. The versioning in here seems quite out of date
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we'll fix the versioning after we finally know which of the (many) other PRs get merged first. |
||
| nk_cos/nk_sin/nk_strtod/nk_memset/nk_memcopy/nk_dtoa | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we are updating the example in the readme. IMO readme examples should be very small and give the reader a taste of how nuklear is to use. Not sure this update really makes it any better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shows elements of nuklear that are often going to be used in applications, but I guess it's preference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually tend to prefer readme examples to be very small. In our case we're pretty much covered by everything in
example/directory. So here I won't advocate for extending the current example.I'm though fine with extending if it's just about 1-5 SLOC which add and I quote "often used elements". That's not the current case though.