Skip to content

Conversation

@RobLoach
Copy link
Contributor

@RobLoach RobLoach commented Dec 22, 2021

Reverts #156

@aganm @Hejsil This change reverts the layout bounds change. May be worth considering removing the change until we fix it for good. What do you think?

@RobLoach RobLoach closed this Dec 22, 2021
@RobLoach RobLoach deleted the revert-156-fix-layout-bounds-padding branch December 22, 2021 19:44
@RobLoach RobLoach restored the revert-156-fix-layout-bounds-padding branch December 24, 2021 18:57
@RobLoach RobLoach reopened this Dec 24, 2021
@RobLoach
Copy link
Contributor Author

@Hejsil Considering #390 , there may be other regressions we're seeing out of this. Mind if we revert and then fix it up afterwards?

@RobLoach RobLoach requested a review from Hejsil December 24, 2021 20:12
@RobLoach RobLoach added the Bug Something isn't working label Dec 24, 2021
@aganm
Copy link
Contributor

aganm commented Dec 25, 2021

I just tried #160 and it had none of the regressions we found with #156.
Some pieces must be missing for it to work correctly.
Personally I would revert #156, double check #160 and pull it in.

@Hejsil
Copy link
Contributor

Hejsil commented Dec 25, 2021

@Hejsil Considering #390 , there may be other regressions we're seeing out of this. Mind if we revert and then fix it up afterwards?

Sure. I dont have much time until January to look into this so lets revert. Sorry for the breakage 🙏

@RobLoach
Copy link
Contributor Author

No worries! Can be difficult to check all features. Hope we can get some automated tests going at some point to check.

@RobLoach RobLoach merged commit 3e91905 into master Dec 26, 2021
@aganm aganm mentioned this pull request Dec 26, 2021
@RobLoach RobLoach deleted the revert-156-fix-layout-bounds-padding branch January 2, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants