Implement multi level column grouping #62
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add groupPath property to BaseGridColumn for hierarchical grouping - Extend GroupDetailsCallback to support level parameter for multi-level groups - Add utility functions for group path handling and multi-level group detection - Implement walkMultiLevelGroups function for rendering hierarchical headers - Update header rendering to support multi-level groups while maintaining backward compatibility - Add multi-level damage handling for proper clipping - Create storybook example demonstrating 3-level hierarchy (Sales Data > Quarters > Months) - Maintain full backward compatibility with existing group property The implementation automatically detects when multi-level groups are used and switches to hierarchical rendering, while falling back to legacy single-level rendering for backward compatibility.
|
Cursor Agent can help with this pull request. Just |
- Use correct SpriteVariant type 'normal' instead of 'header' - Fix drawSprite usage since it returns void, not a number - Remove unused isGroupPathEqual import - Maintain consistent icon positioning with original implementation
The isGroupPathEqual function was created but never used in the implementation. Only areGroupPathsEqualUpToLevel is needed for multi-level group comparison since we need to check if columns belong to the same hierarchy up to a specific level, not just at that exact level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi-level column grouping support using
groupPathfor hierarchical column organization.This enhancement allows columns to be organized into nested groups. It is fully backward compatible, automatically using the new multi-level rendering only when
groupPathis defined, otherwise falling back to the existing single-level grouping. Performance is maintained by this conditional rendering.