Conversation
There was a problem hiding this comment.
Pull request overview
Removes the log_task_exceptions_to_django_logger wrapper from imperial_coldfront_plugin.tasks, aligning task error-reporting with the updated approach described in issue #314 (emailing admins via the django-q logger rather than duplicating exceptions onto the django logger).
Changes:
- Deleted the
log_task_exceptions_to_django_loggerdecorator class and its wrapper assignments. - Promoted the previously-underscored task implementations (e.g.,
_check_ldap_consistency) to the public task entrypoints (e.g.,check_ldap_consistency) by defining them directly under the exported names. - Removed now-unused imports (
functools,Callable).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @cc-a, Could you please check the steps below? I am not sure if I am following the correct steps to update files in both, this submodule repo and the parent coldfront repo. This is what I have done so far (and it creates 2 PRs, one in each of the repos):
|
|
Thanks @SaranjeetKaur. That's fine. We'll address this PR first then update the PR in the development environment repository to point to the merge commit created in main for the plugin before merging that. |
|
Ok thanks @cc-a. Will open this PR for your review then. |
Description
Please include a summary of the change and which issue is fixed (if any). Please also
include relevant motivation and context. List any dependencies that are required for
this change.
Fixes #314
Type of change
Key checklist
python -m pytest)python -m sphinx -b html docs docs/build)pre-commit run --all-files)Further checks