Skip to content

Update linearassembler.py#326

Merged
ben-l-p merged 1 commit intoImperialCollegeLondon:mainfrom
rmorenoramos:patch-1
May 28, 2025
Merged

Update linearassembler.py#326
ben-l-p merged 1 commit intoImperialCollegeLondon:mainfrom
rmorenoramos:patch-1

Conversation

@rmorenoramos
Copy link
Contributor

V2.4 breakes the LinearAeroelastic tests, since the solver is not imported. This pull request restores the working environment for linear simulations by importing the correct solver

V2.4 breakes the LinearAeroelastic tests, since the solver is not imported. This pull request restores the working environment for linear simulations
@ben-l-p
Copy link
Collaborator

ben-l-p commented May 12, 2025

Thanks for investigating this issue - I will double check that this problem doesn't affect other solvers, and then we can look to merge.

@ben-l-p ben-l-p self-assigned this May 18, 2025
@ben-l-p ben-l-p self-requested a review May 18, 2025 16:33
Copy link
Collaborator

@ben-l-p ben-l-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some time to check through what went wrong; I removed this import in the previous PR because my IDE mistakenly said it was an unused import, and yet the code still passed tests for me. Thanks for fixing this issue!

@kccwing
Copy link
Collaborator

kccwing commented May 18, 2025

btw, test for pypi was cancelled because GitHub deprecated the older ubuntu runner again - this has been addressed in #320 - so feel free to merge this - thanks!

@ben-l-p ben-l-p merged commit ca07a63 into ImperialCollegeLondon:main May 28, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants