Skip to content

Conversation

@InAnYan
Copy link
Owner

@InAnYan InAnYan commented Nov 2, 2025

Closes _____

Steps to test

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] I manually tested my changes in running JabRef (always required)
  • [.] I added JUnit tests for changes (if applicable)
  • [.] I added screenshots in the PR description (if change is visible to the user)
  • [.] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [.] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

koppor and others added 11 commits November 1, 2025 17:03
* Replace google cache with caffeine

* cehckstyle

* checkstyle

* add caffeine to jabkit

* add caffeine to jbang

* add caffeine to jbang
Bumps [jablib/src/main/resources/csl-styles](https://github.com/citation-style-language/styles) from `165ad60` to `5f4f6ae`.
- [Release notes](https://github.com/citation-style-language/styles/releases)
- [Commits](citation-style-language/styles@165ad60...5f4f6ae)

---
updated-dependencies:
- dependency-name: jablib/src/main/resources/csl-styles
  dependency-version: 5f4f6aea729cd0debcf42ff34fa8451bd7691d55
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5 to 6.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v5...v6)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [jablib/src/main/abbrv.jabref.org](https://github.com/JabRef/abbrv.jabref.org) from `176c06c` to `8ccb2d2`.
- [Release notes](https://github.com/JabRef/abbrv.jabref.org/releases)
- [Commits](JabRef/abbrv.jabref.org@176c06c...8ccb2d2)

---
updated-dependencies:
- dependency-name: jablib/src/main/abbrv.jabref.org
  dependency-version: 8ccb2d23ceff48565db25eeb4ebac8351d670265
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `javafx` from 25 to 25.0.1.

Updates `org.openjfx:javafx-base` from 25 to 25.0.1

Updates `org.openjfx:javafx-controls` from 25 to 25.0.1

Updates `org.openjfx:javafx-fxml` from 25 to 25.0.1

Updates `org.openjfx:javafx-graphics` from 25 to 25.0.1

Updates `org.openjfx:javafx-swing` from 25 to 25.0.1

Updates `org.openjfx:javafx-web` from 25 to 25.0.1

Updates `org.openjfx:jdk-jsobject` from 25 to 25.0.1

---
updated-dependencies:
- dependency-name: org.openjfx:javafx-base
  dependency-version: 25.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.openjfx:javafx-controls
  dependency-version: 25.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.openjfx:javafx-fxml
  dependency-version: 25.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.openjfx:javafx-graphics
  dependency-version: 25.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.openjfx:javafx-swing
  dependency-version: 25.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.openjfx:javafx-web
  dependency-version: 25.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.openjfx:jdk-jsobject
  dependency-version: 25.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
JabRef#14219)

Bumps [com.autonomousapps:dependency-analysis-gradle-plugin](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) from 3.3.0 to 3.4.1.
- [Changelog](https://github.com/autonomousapps/dependency-analysis-gradle-plugin/blob/main/CHANGELOG.md)
- [Commits](autonomousapps/dependency-analysis-gradle-plugin@v3.3.0...v3.4.1)

---
updated-dependencies:
- dependency-name: com.autonomousapps:dependency-analysis-gradle-plugin
  dependency-version: 3.4.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
JabRef#14218)

Bumps [com.autonomousapps:dependency-analysis-gradle-plugin](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) from 3.3.0 to 3.4.1.
- [Changelog](https://github.com/autonomousapps/dependency-analysis-gradle-plugin/blob/main/CHANGELOG.md)
- [Commits](autonomousapps/dependency-analysis-gradle-plugin@v3.3.0...v3.4.1)

---
updated-dependencies:
- dependency-name: com.autonomousapps:dependency-analysis-gradle-plugin
  dependency-version: 3.4.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…310 (JabRef#14222)

Bumps com.fasterxml.jackson.datatype:jackson-datatype-jsr310 from 2.20.0 to 2.20.1.

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.datatype:jackson-datatype-jsr310
  dependency-version: 2.20.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@InAnYan
Copy link
Owner Author

InAnYan commented Nov 2, 2025

TODO: add metarule

dependabot bot and others added 14 commits November 2, 2025 19:46
JabRef#14221)

Bumps [org.jetbrains.kotlin:kotlin-stdlib-jdk8](https://github.com/JetBrains/kotlin) from 2.2.0 to 2.2.21.
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](JetBrains/kotlin@v2.2.0...v2.2.21)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlin:kotlin-stdlib-jdk8
  dependency-version: 2.2.21
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Oliver Kopp <[email protected]>
…abRef#14228)

Co-authored-by: aikido-autofix[bot] <119856028+aikido-autofix[bot]@users.noreply.github.com>
…abRef#14230)

Co-authored-by: aikido-autofix[bot] <119856028+aikido-autofix[bot]@users.noreply.github.com>
* Don't show stack trace to users

* IntelliJ reformat
* Parameterize tests for Issue676

* Address PR review feedback: refactor parameterized tests to CsvSource textBlock
* Change preferences dialog behaviour so esc key press is not consumed by cell-based controls (ListView/TableView/TreeView/TreeTableView)

* WIP: local changes before rebase

* Changes in the fix

* added changes in the code

* Fix submodules

* add changelog

---------

Co-authored-by: Callum Higginson <[email protected]>
Co-authored-by: Vishakha <[email protected]>
Co-authored-by: Subhramit Basu <[email protected]>
Co-authored-by: Christoph <[email protected]>
* groups: add model classes: AutomaticDateGroup + DateGroup + some basic tests currently only group based on year not months

* model(groups): adding granularity to to model so it can now group by year following month and day, changing  AutomaticDateGroup/DateGroup+ DateGranularity + tests (year/month/day)

* Fix formatting/checkstyle, apply OpenRewrite, add CHANGELOG

* Match OpenRewrite/formatting expected by CI

* Add serialization support for AutomaticDateGroup

- Add AUTOMATIC_DATE_GROUP_ID constant to MetadataSerializationConfiguration
- Implement serializeAutomaticDateGroup() in GroupSerializer
  * Serializes field name
  * Serializes granularity (YEAR/MONTH/FULL_DATE)
- Add AutomaticDateGroup case in serialization switch
- Add getField() and getGranularity() methods to AutomaticDateGroup
- Fix deepCopy() and hashCode() to include granularity

Serialization format: AutomaticDateGroup:name;context;field;granularity;...

* Add deserialization support for AutomaticDateGroup

- Add AutomaticDateGroup and DateGranularity imports to GroupsParser
- Implement automaticDateGroupFromString() method
  * Parse name, context, field from serialized string
  * Parse and convert granularity string to DateGranularity enum
  * Create AutomaticDateGroup with all parameters
  * Restore group details (color, icon, description)
- Add condition check in fromString() to handle AutomaticDateGroup

This enables AutomaticDateGroup to be loaded from .bib files,
completing the save/load cycle with serialization.

* Add comprehensive tests for AutomaticDateGroup serialization

Serialization tests (GroupSerializerTest.java):
- Test YEAR granularity serialization
- Test MONTH granularity serialization
- Test serialization with color, icon, and description
- Verify format: AutomaticDateGroup:name;context;field;granularity;...

Deserialization tests (GroupsParserTest.java):
- Test parsing YEAR granularity
- Test parsing MONTH granularity
- Test parsing FULL_DATE granularity
- Test parsing with color, icon, and description
- Verify correct object reconstruction from string

Total: 7 new test cases covering all granularity types and edge cases.

* Fix: Add missing DateGranularity import to GroupSerializer

* Fix: Remove unused DateGranularity import from GroupSerializer

Checkstyle reported DateGranularity as an unused import because
we only use it through method return type inference (getGranularity().name()).
The import is not needed since we don't declare any variables of this type.

* Add JavaDoc comments to DateGranularity and DateGroup

- Document DateGranularity enum values
- Add class-level documentation for DateGroup
- Ensures these files are detected as changed files in CI for JBang testing

* Add UI components for automatic year groups

* Add Date group functionality for automatic grouping

* Fix the error popping up when right-clicking the group.

* Remove obsolete localization keys from JabRef_en.properties

* Clean up redundant comments in GroupDialogViewModel and GroupNodeViewModel

* test bug fix BibtexParserTest.java:1453

* fix jbang

* turn it back to original case

* Fix submodules

* Fix submodules

---------

Co-authored-by: Sheng Wang <[email protected]>
Co-authored-by: Xu <[email protected]>
Co-authored-by: Xingyu <[email protected]>
Co-authored-by: XingyuDu2025 <[email protected]>
Co-authored-by: Christoph <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants