feat(ast): add visibility support for spec definitions #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all spec definitions were treated as public regardless of visibility modifiers. This change updates the Symbol enum to track spec visibility through a new SpecInfo struct, allowing specs to be properly marked as public or private in the symbol table and type checking process. The AST builder now correctly extracts visibility from spec nodes, and the symbol table registration API updated to accept visibility information. Tests are added to verify both public and private spec visibility parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all spec definitions were treated as public regardless of visibility modifiers. This change updates the Symbol enum to track spec visibility through a new SpecInfo struct, allowing specs to be properly marked as public or private in the symbol table and type checking process.
The AST builder now correctly extracts visibility from spec nodes, and the symbol table registration API updated to accept visibility information. Tests are added to verify both public and private spec visibility parsing.
closes #85