Skip to content

Abstract acceleration sensor and add support for SC7A20 chip used in P8 #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
StarGate01 wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Abstract acceleration sensor and add support for SC7A20 chip used in P8 #1132

StarGate01 wants to merge 4 commits into from

Conversation

@StarGate01
Copy link
Contributor

@StarGate01 StarGate01 commented May 10, 2022 •
edited
Loading

This PR has been broken out of #1050, and depends on / includes #1128 .

  • Abstract the acceleration sensor driver to inherit from the new AccelerationSensor base class
  • Add driver for the SC7A20 chip, use FIFO buffer for smoothing, similar to BMA421: Use internal FIFO for smoothing #1145 .
  • The CMake configuration has been extended to support driver selection via DRIVER_ACC

@StarGate01 StarGate01 mentioned this pull request May 10, 2022
Draft
@StarGate01 StarGate01 mentioned this pull request May 10, 2022
Draft
@StarGate01 StarGate01 force-pushed the p8-acc branch 3 times, most recently from 22a0315 to 649f69b Compare May 15, 2022 22:14
@StarGate01 StarGate01 mentioned this pull request May 15, 2022
Merged
@StarGate01 StarGate01 force-pushed the p8-acc branch 5 times, most recently from 78b1d61 to 586eef2 Compare May 17, 2022 19:22
@StarGate01
Copy link
Contributor Author

StarGate01 commented May 18, 2022 •
edited
Loading

The simulator fails to build because the signature of the constructor Pinetime::System::SystemTask::SystemTask was changed, it now expects a Pinetime::Drivers::AccelerationSensor instead of Pinetime::Drivers::Bma421.

Should I open a PR in InfiniSim?

@Riksu9000
Copy link
Contributor

Riksu9000 commented May 18, 2022

Eventually it will need to be fixed in InfiniSim, however it might be a bit early to do it now.

The fifo changes that affect the PineTime should be one PR, so the other is focused only on the new driver and reviews will be easier.

@StarGate01 StarGate01 force-pushed the p8-acc branch 3 times, most recently from 841eae1 to e474afd Compare May 18, 2022 22:48
@StarGate01 StarGate01 mentioned this pull request May 18, 2022
Draft
@StarGate01
Copy link
Contributor Author

StarGate01 commented May 18, 2022

Ok, I moved the FIFO changes for the BMA421 to #1145 .

@StarGate01 StarGate01 force-pushed the p8-acc branch 5 times, most recently from ca60633 to 17ea323 Compare June 27, 2022 05:39
@StarGate01 StarGate01 mentioned this pull request Jul 7, 2022
Merged
@StarGate01
Acceleration: Abstract sensors into common interface
1d92f8e 
The AccelerationSensor base class provides a unified interface
to access both the BMA421 as well as the SC7A20 chip.
@StarGate01
BMA421: Use AccelerationSensor base class
49da67a
@StarGate01
Acceleration: Add support for SC7A20 chip
8e6c300 
The FIFO buffer is used as well
@StarGate01
CMake: Add acceleration sensor configuration
52b5b72 
The DRIVER_ACC configuration variable can be used to select the
acceleration sensor driver to be used.
@StarGate01 StarGate01 marked this pull request as draft May 13, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StarGate01 @Riksu9000