Skip to content

Conversation

@Riksu9000
Copy link
Contributor

The Counter widget was extended with custom font support, twelve hour mode and value changed callback.

SettingSetTime was reworked to use Counter, along with other small optimizations.

InfiniSim_2022-06-06_213540
InfiniSim_2022-06-06_213542

@kieranc
Copy link
Contributor

kieranc commented Jun 7, 2022

Good move to standardise this with the counter widget, is there a reason why seconds are displayed if they can't be set? I also feel like the title doesn't really need to be displayed, if it (and seconds?) were removed it would allow the counter widget to be larger hence easier to use. Seconds could even be shrunk to match the AM/PM label if there's a reason not to remove it.

@Riksu9000
Copy link
Contributor Author

Seconds are displayed to help roughly set the seconds by timing it when the minute changes.

The only other font size is the 76px one. Using the largest font would make it look just like the Timer app, and I think it's better for them to be more distinct by showing the title for example like in all other settings screens. The best we could do is increase the padding to make the widget larger, but I'd rather keep the padding fixed or a percentage of the font size. The padding is a bit inconsistent due to the differing line heights and widths of the fonts, but I may end up doing something about that.

There are more things to consider like changing font sizes, but I think it's best to take this one step at a time and just use the Counter widget in apps, which already has larger buttons, before making more changes.

@Riksu9000
Copy link
Contributor Author

Riksu9000 commented Jun 8, 2022

I'm thinking of replacing the twelve hour mode with an over/underflow callback. This would be a more generic solution. (Never mind, that's not how 12-hour works and it would me more complicated) Let me know if you have any thoughts about this, or other ideas about how the am/pm label could be controlled by the counter.

@Riksu9000 Riksu9000 added this to the 1.11.0 milestone Jun 30, 2022
@Riksu9000 Riksu9000 merged commit 411f2d1 into InfiniTimeOrg:develop Jul 21, 2022
@Riksu9000 Riksu9000 deleted the set-time-use-counter branch July 21, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants