Date lib as submodule #1183
Merged
Date lib as submodule #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
InfiniSim will also require the CMake include directory to be renamed. |
A directory has been renamed
NeroBurner
reviewed
Jun 16, 2022
NeroBurner
added a commit
to InfiniTimeOrg/InfiniSim
that referenced
this pull request
Jun 26, 2022
Support both the current modified `date/includes` directory and the `date` submodules `date/include` directory. Once InfiniTimeOrg/InfiniTime#1183 is merged and the InfiniTime submodule is checked in also update the GitHub Action and the AUR package. Fixes: #42
NeroBurner
added a commit
to InfiniTimeOrg/InfiniSim
that referenced
this pull request
Jun 26, 2022
Support both the current modified `date/includes` directory and the `date` submodules `date/include` directory. Once InfiniTimeOrg/InfiniTime#1183 is merged and the InfiniTime submodule is checked in also update the GitHub Action and the AUR package. Fixes: #42
NeroBurner
added a commit
to InfiniTimeOrg/InfiniSim
that referenced
this pull request
Jun 26, 2022
Support both the current modified `date/includes` directory and the `date` submodules `date/include` directory. Once InfiniTimeOrg/InfiniTime#1183 is merged and the InfiniTime submodule is checked in also update the GitHub Action and the AUR package. Fixes: #42
NeroBurner
approved these changes
Jun 26, 2022
Contributor
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
supported in InfiniSim with InfiniTimeOrg/InfiniSim#43
JF002
approved these changes
Jul 7, 2022
Collaborator
|
I wanted to re-run the simulator workflow to check that everything is fine with this PR but... I can't find any way to launch de workflow manually. Anyway, I checked manually and it works fine for me! Thanks for the change in InfiniSim, @NeroBurner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the date directory and create a submodule in it's place. The specific commit is the same one that was used before.