Skip to content

Conversation

@Riksu9000
Copy link
Contributor

No reason to run these checks in that case.

Copy link
Member

@FintasticMan FintasticMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the .devcontainer, .idea, .vscode and hooks directories can be excluded as well

@Riksu9000 Riksu9000 added this to the 1.11.0 milestone Jun 30, 2022
@Riksu9000
Copy link
Contributor Author

Riksu9000 commented Jun 30, 2022

I think that the .devcontainer, .idea, .vscode and hooks directories can be excluded as well

I've been trying to think of another solution than explicitly mention multiple directories in multiple places, but haven't figured out a solution yet. I think it's best to just ignore the few directories that definitely don't have anything to do with code for now.

@FintasticMan
Copy link
Member

I've been trying to think of another solution than explicitly mention multiple directories in multiple places, but haven't figured out a solution yet.

All I can think of is still running the workflow, but checking if there is a file called something like .nobuild in the directory of the changes or any of its parents, and if so just saying that the test passed.

@Riksu9000 Riksu9000 merged commit b9f5a07 into InfiniTimeOrg:develop Jul 5, 2022
@Riksu9000 Riksu9000 deleted the workflow-ignore-dirs branch July 5, 2022 06:22
@pfeerick
Copy link
Contributor

pfeerick commented Jul 8, 2022

You can also ignore by file extension... i.e.

    paths-ignore:
      - '**.md'

ignores changes to markdown files regardless of where in the repo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants