Skip to content

P8: Mirror display for P8b variant #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JF002 merged 1 commit into from
Aug 15, 2022
Merged

P8: Mirror display for P8b variant #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,7 @@ elseif(TARGET_DEVICE STREQUAL "MOY-UNK") # P8b mirrored
add_definitions(-DCLOCK_CONFIG_LF_SRC=0) # RC
add_definitions(-DMYNEWT_VAL_BLE_LL_SCA=500)
add_definitions(-DCLOCK_CONFIG_LF_CAL_ENABLED=1)
add_definitions(-DDRIVER_DISPLAY_MIRROR)
else()
message(FATAL_ERROR "Invalid TARGET_DEVICE")
endif()
Expand Down
14 changes: 14 additions & 0 deletions src/drivers/St7789.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ void St7789::Init() {
MemoryDataAccessControl();
ColumnAddressSet();
RowAddressSet();
// P8B Mirrored version does not need display inversion.
#ifndef DRIVER_DISPLAY_MIRROR
DisplayInversionOn();
#endif
NormalModeOn();
SetVdv();
DisplayOn();
Expand Down Expand Up @@ -62,7 +65,18 @@ void St7789::ColMod() {

void St7789::MemoryDataAccessControl() {
WriteCommand(static_cast<uint8_t>(Commands::MemoryDataAccessControl));
#ifdef DRIVER_DISPLAY_MIRROR
// [7] = MY = Page Address Order, 0 = Top to bottom, 1 = Bottom to top
// [6] = MX = Column Address Order, 0 = Left to right, 1 = Right to left
// [5] = MV = Page/Column Order, 0 = Normal mode, 1 = Reverse mode
// [4] = ML = Line Address Order, 0 = LCD refresh from top to bottom, 1 = Bottom to top
// [3] = RGB = RGB/BGR Order, 0 = RGB, 1 = BGR
// [2] = MH = Display Data Latch Order, 0 = LCD refresh from left to right, 1 = Right to left
// [0 .. 1] = Unused
WriteData(0b01000000);
#else
WriteData(0x00);
#endif
}

void St7789::ColumnAddressSet() {
Expand Down