SystemInfo: Display target build variant #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarGate01
force-pushed
the
display-variant
branch
2 times, most recently
from
e22f875 to
b599af9
Compare
Riksu9000
approved these changes
Jun 27, 2022
|
Curious to know what name shows up on the PineTime... Just PineTime, PineTime1 (or PineTime2, since later variants of the PineTime had some hardware changes, etc.) |
Contributor
Author
|
@ajack2001my since the string used is just the CMake target name, it will be "PINETIME". Other hardware differences will be listed in e.g. the accelerometer variant. |
NeroBurner
approved these changes
Jul 3, 2022
StarGate01
force-pushed
the
display-variant
branch
from
b599af9 to
b5890f0
Compare
JF002
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been broken out of #1050, and depends on / includes #1128 .
This PR uses the last line on the second screen in the system information to display the target build variant, i.e. which device the firmware was compiled for. This is very useful to know which updates to download, once you have forgotten which variant your device is.