Limit backlight brightness when flashlight is off #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JF002
approved these changes
Jul 4, 2022
NeroBurner
reviewed
Jul 4, 2022
|
Based on your description it seems that opening the flashlight app now sets the brightness to low. Instead of fixing the referenced issue, it now behaves nearly opposite and in a similar strange way. Is there any reason why the brightness is set to low instead of keeping the globally set brightness value? |
Contributor
Author
|
@mashuptwice Please read the discussion here #1212 (comment). The issue was the backlight switching to bright on starting the app and that has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backlight brightness is unlimited while the flashlight is on.
While it is off, the brightness is limited
to the global backlight levelto low.Small code optimizations.
Fixes #1210