Docker workflow use separate username for login #1227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JF002 This pull request fixes the issue mentioned here about that the username used for logging in to Docker Hub is different than the one that actually has the images. This works around it by having 2 secrets:
DOCKER_HUB_LOGIN_USERNAME, which should be set to (in this case)jf002, andDOCKER_HUB_IMAGE_USERNAME, which should be set toinfinitime.I don't have an organisation on Docker Hub to test it out on, but I have tested it on my personal repository, with both secrets set to
fintasticman, and it works fine.