Counter: Determine the number of digits from the max value.

[Riksu9000]

Previously the minimum number of digits was fixed at two, padded with leading zeros if necessary. Now it will be determined from the max value.

Current:
00, 01, 02 ... 99, 100, 101 ... 999, 1000 1001

With this change:
0000, 0001, 0002 ... 0099, 0100, 0101 ... 0999, 1000, 1001

This issue doesn't happen with the current uses of the Counter.

[Riksu9000]

@lman0 I think you're misunderstanding what this PR is about. Please familiarize yourself with the code.

[Riksu9000]

@lman0 I've updated the description, but as this is an entirely technical change and essentially a bugfix, I would rather have feedback from devs.

[JF002]

@lman0 Github is a developer tool, and more especially the pull request functionality : developers write changes or additions and request core-developers/maintainers to pull those changes into the main code base.
We do this in the public space, anyone is free to read and interact in the comment, but we do not expect everyone to understand everything that is being done or discussed in those comments.

As a developer, I can easily see that this PR only changes the formatting of the leading 0s based on the maximum value the widget is supposed to display. The changes are quite simple and documented enough in the description. I do not need more information.

You are of course free to ask questions and speak your opinion on any pull-requests or issues in the project, but remember that we are under no obligation to answer all of them. Answering those questions and debating endlessly on insignificant details or on topics that you seem to not understand is very time consuming for us and counter productive, and we hide comments when we feel like we are loosing our time.

If you want to contribute to the project (and I think you really want to), please try to be a bit more organized : comment on topics where you really think you can provide additional value, do not question each and every change done by developers, think a bit more before publishing your comments to avoid multiple edits afterwards, and, if you think you have a good/better idea, try to contribute it yourself.

[lman0]

@lman0 I've updated the description, but as this is an entirely technical change and essentially a bugfix, I would rather have feedback from devs.

thanks for the update !

@JF002 @Riksu9000 i've seen on other projects that tag "technical" were added to prs to say it's an entirely technical ( not visual or app ) change so user like me not pry.
that could be helpful