Merge CI to deduplicate events #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think it makes sense that building the firmware, the simulator and checking the code formatting should be triggered at the same time, yes. So merging those 3 workflows in 1 totally make sense. I'll ask @Avamander and @NeroBurner opinion as (I think) they wrote those 2 additional workflows ;-) |
NeroBurner
approved these changes
Aug 21, 2022
Contributor
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
as long as we see with the checks which of the jobs failed I'm OK with the change
Contributor
Author
|
I'll merge this as I think we always want to build the firmware and the simulator at the same time. |
ghost
mentioned this pull request
feduss
pushed a commit
to feduss/CustomInfiniTime
that referenced
this pull request
Sep 11, 2022
minacode
pushed a commit
to minacode/InfiniTime
that referenced
this pull request
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have multiple checks in one file as different jobs that get triggered with the same events. The main workflow should run when there are changes that may affect the builds.
Do you think the code formatting check should also be moved here? It has slightly different triggering events, but can be tweaked to work. (Maybe there isn't a good reason to do so)