fix: ordered list numbers alignment and style override #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Infinitix-LLC#105 ## Problems Fixed 1. **Alignment Issue**: Ordered list numbers (1., 2., 10., etc.) were not vertically aligned because numbers had variable width based on digit count. 2. **Style Override Issue (Infinitix-LLC#105)**: Ordered list numbers were forcing fontWeight: FontWeight.w100, overriding user-configured text styles. ## Solution ### For Alignment: - Calculate width dynamically using TextPainter based on '99.' width - This adapts to different font sizes automatically - Apply right-alignment (TextAlign.right) for LTR text - Apply left-alignment (TextAlign.left) for RTL text ### For Style Override: - Remove the forced fontWeight override in OrderedList component - Pass through config.style directly to OrderedListView ## Changes 1. `unordered_ordered_list.dart`: - Add optional `numberWidth` parameter to `OrderedListView` - Calculate width dynamically using current font style if not specified - Use '99.' as reference to accommodate lists up to 99 items - Wrap number Text in SizedBox with proper text alignment 2. `markdown_component.dart`: - Remove forced `fontWeight: FontWeight.w100` override - Pass `config.style` directly to OrderedListView ## Testing - flutter analyze passes - flutter test passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two related issues with ordered list rendering:
Fixes Ordered list number's font overrides font settings #105
Changes
numberWidthparameter for manual overridefontWeight: FontWeight.w100overrideTesting
flutter analyzepassesflutter testpasses