Merged
Conversation
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
Updated Windows Docker image base from plain mcr.microsoft.com/windows/nanoserver:ltsc2022 to mcr.microsoft.com/powershell:nanoserver-ltsc2022, which includes PowerShell preinstalled on the same nanoserver base.
Key Changes
- Single line change in the Dockerfile
- Maintains same nanoserver ltsc2022 base OS version
- Adds PowerShell runtime environment without increasing image complexity
- No changes to the COPY or ENTRYPOINT commands
Assessment
This is a clean improvement that enables PowerShell functionality in the Windows container without requiring users to install it separately. The change is minimal, uses an official Microsoft base image, and maintains the same OS version (ltsc2022) for consistency.
Confidence Score: 5/5
- This PR is safe to merge with minimal risk - single-line change using official Microsoft base image
- The change is extremely simple and low-risk: switching from one official Microsoft base image to another that includes PowerShell. Both images use the same nanoserver ltsc2022 base, so there are no compatibility concerns. The image tag was verified to exist in Microsoft's container registry. No code logic or security-sensitive configurations were modified.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| docker/windows | 5/5 | Changed base image from plain nanoserver to nanoserver with PowerShell preinstalled - straightforward and safe improvement |
Sequence Diagram
sequenceDiagram
participant User
participant DockerBuild as Docker Build Process
participant MCR as Microsoft Container Registry
participant Container as Windows Container
User->>DockerBuild: Build Windows Docker Image
DockerBuild->>MCR: Pull mcr.microsoft.com/powershell:nanoserver-ltsc2022
MCR-->>DockerBuild: Return base image with PowerShell
DockerBuild->>DockerBuild: COPY infisical.exe to /infisical.exe
DockerBuild->>DockerBuild: Set ENTRYPOINT to C:\infisical.exe
DockerBuild-->>User: Windows container image ready
User->>Container: Run container
Container->>Container: Execute infisical.exe (with PowerShell available)
Container-->>User: CLI running with PowerShell support
1 file reviewed, no comments
x032205
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Updated windows docker image to nanoserver with powershell installed.
Type ✨