Skip to content

fix: add powershell to windows image#38

Merged
varonix0 merged 1 commit intomainfrom
daniel/update-windows-base-image
Oct 15, 2025
Merged

fix: add powershell to windows image#38
varonix0 merged 1 commit intomainfrom
daniel/update-windows-base-image

Conversation

@varonix0
Copy link
Member

Description 📣

Updated windows docker image to nanoserver with powershell installed.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

@varonix0 varonix0 self-assigned this Oct 15, 2025
@varonix0 varonix0 requested a review from maidul98 October 15, 2025 22:38
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

Updated Windows Docker image base from plain mcr.microsoft.com/windows/nanoserver:ltsc2022 to mcr.microsoft.com/powershell:nanoserver-ltsc2022, which includes PowerShell preinstalled on the same nanoserver base.

Key Changes

  • Single line change in the Dockerfile
  • Maintains same nanoserver ltsc2022 base OS version
  • Adds PowerShell runtime environment without increasing image complexity
  • No changes to the COPY or ENTRYPOINT commands

Assessment

This is a clean improvement that enables PowerShell functionality in the Windows container without requiring users to install it separately. The change is minimal, uses an official Microsoft base image, and maintains the same OS version (ltsc2022) for consistency.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - single-line change using official Microsoft base image
  • The change is extremely simple and low-risk: switching from one official Microsoft base image to another that includes PowerShell. Both images use the same nanoserver ltsc2022 base, so there are no compatibility concerns. The image tag was verified to exist in Microsoft's container registry. No code logic or security-sensitive configurations were modified.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
docker/windows 5/5 Changed base image from plain nanoserver to nanoserver with PowerShell preinstalled - straightforward and safe improvement

Sequence Diagram

sequenceDiagram
    participant User
    participant DockerBuild as Docker Build Process
    participant MCR as Microsoft Container Registry
    participant Container as Windows Container

    User->>DockerBuild: Build Windows Docker Image
    DockerBuild->>MCR: Pull mcr.microsoft.com/powershell:nanoserver-ltsc2022
    MCR-->>DockerBuild: Return base image with PowerShell
    DockerBuild->>DockerBuild: COPY infisical.exe to /infisical.exe
    DockerBuild->>DockerBuild: Set ENTRYPOINT to C:\infisical.exe
    DockerBuild-->>User: Windows container image ready
    User->>Container: Run container
    Container->>Container: Execute infisical.exe (with PowerShell available)
    Container-->>User: CLI running with PowerShell support
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@varonix0 varonix0 merged commit 92257f2 into main Oct 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants