Skip to content

fix: allow empty secret values when setting secrets from .env file #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shashwat-dixit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow empty secret values when setting secrets from .env file #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/util/secrets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ func SetRawSecrets(secretArgs []string, secretType string, environmentName strin
PrintErrorMessageAndExit(err.Error())
}
if strings.TrimSpace(value) == "" {
PrintErrorMessageAndExit(fmt.Sprintf("Secret key '%s' has an empty value", key))
PrintWarning(fmt.Sprintf("Secret key '%s' has an empty value", key))
}
secretArgs = append(secretArgs, fmt.Sprintf("%s=%s", key, value))
}
Expand Down Expand Up @@ -705,8 +705,8 @@ func SetRawSecrets(secretArgs []string, secretType string, environmentName strin

for _, arg := range secretArgs {
splitKeyValueFromArg := strings.SplitN(arg, "=", 2)
if splitKeyValueFromArg[0] == "" || splitKeyValueFromArg[1] == "" {
PrintErrorMessageAndExit("ensure that each secret has a none empty key and value. Modify the input and try again")
if splitKeyValueFromArg[0] == "" {
PrintErrorMessageAndExit("ensure that each secret has a non empty key. Modify the input and try again")
}

if unicode.IsNumber(rune(splitKeyValueFromArg[0][0])) {
Expand Down