feat(eng-4621): add recent login awareness to login page#5583
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile SummaryThis PR adds "recent login awareness" to the frontend login page: the last-used login method (plus org slug for SAML/OIDC/LDAP) is persisted to Key issues found:
These timing inconsistencies mean the "Last used" state can become incorrect or stale across different login flows. Confidence Score: 3/5
Last reviewed commit: 6ae37ad |
frontend/src/pages/auth/LoginPage/components/InitialStep/InitialStep.tsx
Show resolved
Hide resolved
Additional Comments (2)
The
For SAML and OIDC, The practical impact: if a user submits with a wrong or non-existent org slug, the incorrect slug is still stored in localStorage and will be pre-filled on the next visit. Since the window closes regardless of the outcome, the user has no indication the login failed, and they'll arrive back at a pre-filled slug that doesn't work. While SSO redirect flows make it impossible to hook into server-side success the same way as credential logins, consider adding a comment documenting this known behavioral difference between the flows, or add a client-side validation check before persisting (e.g., ensure |
6ae37ad to
f4377b4
Compare
f4377b4 to
6bbf3c5
Compare
scott-ray-wilson
left a comment
There was a problem hiding this comment.
Overall logic looks good - two comments and one suggestion 👍
frontend/src/pages/auth/LoginPage/components/InitialStep/InitialStep.tsx
Show resolved
Hide resolved
frontend/src/pages/auth/LoginPage/components/OrgLoginButton.tsx
Outdated
Show resolved
Hide resolved
abe60df to
9fe7902
Compare
scott-ray-wilson
left a comment
There was a problem hiding this comment.
Nice QoL improvement 👍

Summary