feat(pki-118): add spiffe machine auth#5610
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile SummaryThis PR introduces SPIFFE machine authentication with a complete service, router, schema, and frontend components. However, it has critical blockers that prevent it from functioning: Critical Issues:
Security Issues:
These must be resolved before merging. Confidence Score: 0/5
Last reviewed commit: 96245d2 |
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-fns.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-validators.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-service.ts
Outdated
Show resolved
Hide resolved
akhilmhdh
left a comment
There was a problem hiding this comment.
Pending application testing. I'll do it after we address these changes.
The db schema diff test is also failing. Please fix that as well.
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-service.ts
Show resolved
Hide resolved
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-service.ts
Show resolved
Hide resolved
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-service.ts
Show resolved
Hide resolved
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-service.ts
Outdated
Show resolved
Hide resolved
832394f to
79b44dd
Compare
backend/src/services/identity-spiffe-auth/identity-spiffe-auth-types.ts
Outdated
Show resolved
Hide resolved
79b44dd to
550c544
Compare
abf172e to
7cebfc1
Compare
7cebfc1 to
f2f10f9
Compare
Context
Screenshots
TODO
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).