Skip to content

Conversation

@victorvhs017
Copy link
Contributor

This PR adds support for Dynamic Secrets to the Python SDK, including operations to get, create, update, and delete Dynamic Secrets.

It also adds Dynamic Secrets Leases operations: get, create, delete, and renew.

…e, delete, get, and update functionalities
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 20, 2025

Greptile Summary

This PR adds comprehensive support for Dynamic Secrets to the Python SDK, including operations for managing dynamic secrets (get, create, update, delete) and their leases (get, create, delete, renew).

  • Added DynamicSecretProviders enum with 21 provider types (AWS IAM, SQL databases, MongoDB, Redis, etc.)
  • Implemented DynamicSecrets and DynamicSecretLeases resource classes following existing SDK patterns
  • Added proper data models (DynamicSecret, DynamicSecretLease) with custom from_dict methods for nested object handling
  • Uses urllib.parse.quote with safe='' for secure URL path encoding
  • Follows existing SDK architecture and coding patterns consistently

Confidence Score: 4/5

  • This PR is safe to merge - it adds new functionality without modifying existing behavior.
  • New feature addition following established SDK patterns. URL parameters are properly encoded to prevent injection. Minor design question about the update method's data vs inputs parameters, but not blocking.
  • Pay attention to infisical_sdk/resources/dynamic_secrets.py - specifically the update() method's parameter design.

Important Files Changed

Filename Overview
infisical_sdk/init.py Added DynamicSecretProviders enum to module exports, enabling users to access provider types directly from the package.
infisical_sdk/api_types.py Added data types for dynamic secrets including DynamicSecretProviders enum, DynamicSecret, DynamicSecretLease, and response models with proper nested object handling in from_dict methods.
infisical_sdk/client.py Integrated DynamicSecrets resource into the SDK client, exposing dynamic_secrets attribute for API access.
infisical_sdk/resources/init.py Added DynamicSecrets export to resources module.
infisical_sdk/resources/dynamic_secrets.py New implementation for Dynamic Secrets and Leases management with CRUD operations. Uses proper URL encoding for path parameters. The update method has both data and inputs parameters which may need clarification.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@victorvhs017
Copy link
Contributor Author

@greptileai re-review and update summary

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

…oving unused fields and updating method signatures for clarity
@varonix0 varonix0 force-pushed the feature/add-dynamic-secrets-support branch from a64b48c to 1300c27 Compare December 24, 2025 13:03
@varonix0 varonix0 merged commit b644202 into main Dec 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants