fix: use WriteOptions from ClientConfig on write#239
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 90.10% 90.11%
=======================================
Files 20 20
Lines 1193 1194 +1
Branches 187 187
=======================================
+ Hits 1075 1076 +1
Misses 41 41
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
karel-rehor
approved these changes
Jun 4, 2025
Contributor
karel-rehor
left a comment
There was a problem hiding this comment.
Tests pass locally. All changes make sense. 🚴 🏁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue
If the client is configured as:
then the
ignores the configured write precision and uses the default precision.
Proposed Changes
The following 4 write functions in
InfluxDBClientImplnow are gettingWriteOptionsfromClientConfig config, (instead of the previously usedWriteOptions.DEFAULTS):Checklist