Conversation
2312f8c to
410bb85
Compare
bednar
requested changes
Jan 21, 2026
Member
bednar
left a comment
There was a problem hiding this comment.
It looks good, just small requirement:
acb5d3e to
9ef0f79
Compare
bednar
approved these changes
Jan 21, 2026
Member
bednar
left a comment
There was a problem hiding this comment.
LGTM 🚀
Please merge PR after the CI checks pass.
371566f to
96ce3ef
Compare
785bc1e to
9439466
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes PR
Proposed Changes
NodeHttpTransport.testtoe2e.testand use the real NodeJS HTTP module, so the event will be more consistent (Nock does not work like the 100% http module, it just mimics some behavior).communicates through a proxy test caseto use the real HTTP module because Nock has changed the way they handle the url so the previous test case failed.fails on write response status not being 2xxuse a valid response status, previous100status were not allowed by Nock.It's hard to know which events will be emitted from Nodejs, these new events and test cases are just based on my trial and errors method.
There is a linter error because we updated github/super-linter from v5 to v7; this needs a separate PR to fix the new github/super-linter asks, so please ignore it in this PR.
Checklist