Conversation
…epare query ticket and options
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 61.63% 61.92% +0.28%
==========================================
Files 33 33
Lines 2101 2135 +34
==========================================
+ Hits 1295 1322 +27
- Misses 806 813 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansimonb
reviewed
Mar 20, 2025
bednar
requested changes
Mar 24, 2025
CHANGELOG.md
Outdated
|
|
||
| ### Features | ||
|
|
||
| 1. [123](https://github.com/InfluxCommunity/influxdb3-python/pull/123): Introduces `query_async` method. |
Member
There was a problem hiding this comment.
Please update the CHANGELOG to outline the next steps for achieving full asyncio support—e.g., indicating if the next PR will add async write functionality or something else along those lines.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
query_asyncmethod toquery_apiquery_apiquery_asyncmethod wrap call toFlightClient.doGetin current event loop retrieved fromasyncioquery_asyncmethod wrapFlightStreamReadertranslations in same event loopquery_apiInfluxDBClient3expose these changes with newquery_asyncmethodInfluxDBClient3tests/utilquery_api.__init__()improve merge of_flight_client_optionsso that some values do not get dropped or overwrittenChecklist