feat: support env

[NguyenHoangSon96]

Closes Issue

Proposed Changes

• Support creates InfluxDB client with environment variables with the same name as the Go client

Checklist

• CHANGELOG.md updated
• Rebased/mergeable
• A test has been added if appropriate
• Tests pass
• Commit messages are conventional
• Sign CLA (if not already signed)

[codecov]

Codecov Report

Attention: Patch coverage is 96.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.84%. Comparing base (93129b0) to head (ec8813c).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
influxdb_client_3/write_client/client/write_api.py	76.92%	3 Missing ⚠️
influxdb_client_3/__init__.py	98.85%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   61.92%   63.84%   +1.92%     
==========================================
  Files          33       33              
  Lines        2135     2246     +111     
==========================================
+ Hits         1322     1434     +112     
+ Misses        813      812       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jansimonb]

I think config from environment variables was already supported (see method from_env_properties). What you should support is:

• different set of environment variable names (same as in go -- https://github.com/InfluxCommunity/influxdb3-go/blob/main/influxdb3/client.go#L258-L267)
• plus also keep it backward compatible, so it should work with both the old names and the new names

[NguyenHoangSon96]

I think config from environment variables was already supported (see method from_env_properties). What you should support is:

• different set of environment variable names (same as in go -- https://github.com/InfluxCommunity/influxdb3-go/blob/main/influxdb3/client.go#L258-L267)
• plus also keep it backward compatible, so it should work with both the old names and the new names

Hi Jan
I don't get it
from_env_properties supports names with v2 in its string
My new function supports names like in golang
"INFLUX_HOST"
"INFLUX_TOKEN"
"INFLUX_DATABASE"
"INFLUX_ORG"

[NguyenHoangSon96]

Hi @jansimonb
I pushed the latest code. Please take a look when you have time
I converted to draft because I'm not very confident with the fix 🙈
I have not added comments for new functions...

[karel-rehor]

As for the V2 values in InfluxDBClient.from_env_properties() these are relics of the original copy and paste from the V2 client libraries roughly two years ago. Perhaps we should mark it as @deprecated

e.g.

    @deprecated("Use up to date Env Properties")
    @classmethod
    def from_env_properties(cls, debug=None, enable_gzip=False, **kwargs):

[karel-rehor]

This could be a @classmethod on InfluxDBClient3 See https://github.com/influxdata/influxdb-client-python/blob/74013566a9df3e41dc1ef67cda0cbd0f6b83c733/influxdb_client/client/influxdb_client.py#L180

Also since most of these options are passed to write_options maybe it would be cleaner to have a class method there as well. e.g.

class WriteOptions(object):
...
    @classmethod
    def from_envars(cls, debug=None, enable_gzip=False, **kwargs):
        url = os.getenv('INFLUX_HOST', "http://localhost:8086")
        ...

[NguyenHoangSon96]

Hi @karel-rehor
I had upgraded the from_env function
Can you check again and see if we still need to implement a separated function in WriteOptions

[karel-rehor]

One comment went missing in last review. Retrieved it here.

[jansimonb]

In from_env_properties (what we want to deprecate) there are 13 environment variables supported. In the new from_env we support 7 env variables. Does that mean that we are loosing some functionality? E.g. is it still possible to use the new from_env method but also configure connection_pool_maxsize?

[NguyenHoangSon96]

In from_env_properties (what we want to deprecate) there are 13 environment variables supported. In the new from_env we support 7 env variables. Does that mean that we are loosing some functionality? E.g. is it still possible to use the new from_env method but also configure connection_pool_maxsize?

Hi @jansimonb
I have increased the number of parameters we support
Please check again