refactor: use local assets #1483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliverDudgeon
force-pushed
the
assets-test
branch
from
4921724 to
c5800d0
Compare
OliverDudgeon
had a problem deploying
to
data-manager-ui/test
GitHub Actions
Failure
OliverDudgeon
had a problem deploying
to
data-manager-ui/test
GitHub Actions
Failure
OliverDudgeon
had a problem deploying
to
data-manager-ui/test
GitHub Actions
Failure
OliverDudgeon
had a problem deploying
to
data-manager-ui/test
GitHub Actions
Failure
git-subtree-dir: assets git-subtree-split: 7aa599736b0d4d0dc854f52b7218972312cbd730
OliverDudgeon
force-pushed
the
assets-test
branch
from
b9f4f04 to
4f517b7
Compare
OliverDudgeon
had a problem deploying
to
data-manager-ui/test
GitHub Actions
Failure
OliverDudgeon
had a problem deploying
to
data-manager-ui/test
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, assets (images and fonts) hosted on squonk.informaticsmatter.org were used. Although this worked ok there were several issues with this method.
This PR brings the assets into a local folder via a Git subtree to a new repo. The images are then directly accessed using the NextJS
Imagetag, which has optimization benefits. The fonts are now loaded locally with thenext/fontmodule rather than our SASS loader. This allows us to remove the dependency on SASS entirely. It, additionally, can bring some optimizations via the next/font library to reduce bad behaviours like layout shift.