fix: Combiners no longer get built-in variables automatically #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristie-im
pushed a commit
that referenced
this pull request
Dec 3, 2025
* feat: kind-version now 2025.2 BREAKING CHANGE * feat: Initial schema for replicate step declaration * feat: Add get_generated_outputs_for_step_output() to API adapter * feat: Rename new API method * feat: Add replica to step creation (and step-by-name query) * feat: Removed 'as' from workflow mapping output declaration * feat: Add get_running_workflow_step_output_values_for_output() to API * fix: Removed rogue 'print' statement * test: Add mock of step outputs * fix: it's a mess * docs: Add instance-directory comment * feat: Creating instances now adds instance-directory property to step record * fix: get_instance() response type * test: Add tests for instance_directory * build: Add experimental json copy of the schema * style: Removed unnecessary json schema file * fix: Better rfc1035-label-name pattern * fix: Better rfc1035-label-name regex * test: Fix decoder tests * test: Fix test module name (for consistency) * Remove unnecessary logic * fix: stashing * fix: stashing * refactor: Major refactor (new variable-mapping schema) * refactor: from-workflow-variable becomes from-workflow * refactor: from-workflow-variable becomes from-workflow * refactor: Replicate now uses variable not input * fix: No longer need realise-outputs * build: Add devcontainer * build: No need for DinD * docs: Docs on devcontainer * docs: Doc tweak * feat: Some work on the refactored engine * fix: More fixes for engine * fix: More work on the decoder * fix: Variable mapping now exposed as a Translation dataclass * fix: Major refactoring of logic (for new launch/workflow API) * feat: First successful replicating workflow test * feat: Use of decoder 2.4.0 (traits) * refactor: Switch away from workflow replicate property * refactor: Refactored using decoder 2.5.0 * docs: Doc tweak * refactor: variable-map is now 'plumbing' and Translation is a 'Connector' * refactor: Better function and variable naming (plumbing) * feat: new _prepare_step_variables function * feat: Refactoring * refactor: More combiner logic * feat: refactor definition of an output * fix: Add get_status_of_all_step_instances_by_name implementation (and fix step replicas) * docs: Doc tweak * fix: Typo in YAML * feat: Minor work on combiner logic * fix: First very basic combiner run * docs: Doc tweak * fix: replica always starts at 0 * docs: Doc tweak * feat: Add from-link-prefix variables * feat: Switch to pre-defined variables (rather then link) * fix: Fix input output hanes in decoder * fix: Add from-project support * refactor: lin-prefix becomes link-glob * fix: Return kwargs to launch() * feat: Add dependent_instances to LaunchParameters * feat: Populate dependent_instances * refactor: link-glob is now instance-link-glob * refactor: Remove to/from project schema * feat: Add outputs to step prepration response * test: Attempt to fix tests * test: Fix instance creation * fix: Fix test execution * docs: Significant level of module documentation * docs: More docs * docs: Doc tweak * docs: More doc and typo corrections * docs: Code typos corrected * dev: Logs end of step and end of running workflow * dev: Engine now collects inputs and sets LP inputs & outputs * style: Log inputs * dev: Fix handling of launch() result * fix: Better handling of get_running_workflow_step_by_name() response * feat: Engine now attempts to prefix inputs (from prior steps) * fix: Fix prior-step prefix * fix: Launch parameter sets are now lists * dev: fix build * docs: Doc tweak * dev: Fix instance prefix * fix: Engine now handles lack of job better * fix: Validator now ensures jobs exist (run-level test) * fix: Better testing of validation (job must be present) * feat: Better validation error message * test: Fix tests * fix: Better handling of lack of outputs * docs: Doc tweak * fix: Fix iteration input path * test: Disable unit test * fix: Support for dirsGlob * fix: Better step preparation initial log (combiners) * fix: Combiners no longer get built-in variables automatically (#39) --------- Co-authored-by: Alan Christie <[email protected]> Co-authored-by: Kalev Takkis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.