Skip to content

Better workflow start error handling #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alanbchristie merged 1 commit into from
Jan 13, 2026
Merged

Better workflow start error handling #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions workflow/workflow_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ def _handle_workflow_start_message(self, r_wfid: str) -> None:

The first step is relatively easy (?) - all the variables
(for the first step's 'command') will (must) be defined
in the RunningWorkflow's variables."""
in the RunningWorkflow's variables.

The step is not launched if there's an error preparing the step."""

rwf_response, _ = self._wapi_adapter.get_running_workflow(
running_workflow_id=r_wfid
Expand All @@ -224,7 +226,15 @@ def _handle_workflow_start_message(self, r_wfid: str) -> None:
sp_resp = self._prepare_step(
wf=wf_response, step_definition=first_step, rwf=rwf_response
)
assert sp_resp.error_msg is None
if sp_resp.error_msg:
self._wapi_adapter.set_running_workflow_done(
running_workflow_id=r_wfid,
success=False,
error_num=sp_resp.error_num,
error_msg=sp_resp.error_msg,
)
return

# Launch it.
# If there's a launch problem the step (and running workflow) will have
# and error, stopping it. There will be no Pod event as the launch has failed.
Expand Down