Fix expiration date logic to use latest entitlement end date#153
Open
vijaidjearam wants to merge 1 commit intoInfotelGLPI:masterfrom
Open
Fix expiration date logic to use latest entitlement end date#153vijaidjearam wants to merge 1 commit intoInfotelGLPI:masterfrom
vijaidjearam wants to merge 1 commit intoInfotelGLPI:masterfrom
Conversation
Fix expiration date logic to use latest entitlement end date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A device can have multiple entitlements, each with its own
endDate.When determining the expiration date, we need to return the latest (maximum) end date, since that represents the actual final expiration of coverage.
However, using:
selects the earliest (minimum) date, which results in:
✅ Correct Logic
To properly determine the expiration date, we must keep the comparison as:
This ensures that:
$max_dateis initialized.