[CP-349] Extends Testnetify to support multi valset #60

nmarcetic · 2025-05-26T15:26:35Z

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

* * Bump SDK to use CometBFT to v1.0.1 and CometBFT api * Add CometBFT v1 buf registry commit to buf.yaml * Update tendermint to comet import in proto files * Replace tendermint to comet imports in Go files * Remove deprecated sr25519 support starting from CometBFT v1.0.1 * Update SDK go.mod to use local ./api, which is upgraded to Comet v1, instead of cosmossdk.io/api v0.7.5 * Generate proto and pulsar files and remove tendermint from ./proto * fix API breaks of ABCI types in baseapp * import cometBFT protocolbuffers in api * fix node comet wrapper breaking changes * gen protos and fix nits in abci tests * generate proto and pulsar files * * Bump comet to v1 in x/nft, x/feegrant/, x/evidence and store * Remove go toolchain from go.mod files * Revert renaming of query types in store by error * * Update buf.yaml to latest Comet BSR commit * Generate pulsar files * Fix ABCI unit test in baseapp * Fix genesis tests * Remove Go toolchains * Fix remaining breaking changes of Comet v1 ABCI types * Add synchrony and features params to MsgUpdateParams in x/consensus * feat: add core and api for PreBlock (cosmos#17468) * feat(api): add autocli options to enhance custom commands (cosmos#17033) * feat(client): add positional optional to client v2 (cosmos#16316) Co-authored-by: Julien Robert <[email protected]> * fix slashing UT * feat(client/v2): override short description in generated command (cosmos#20266) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * refactor(baseapp): create checktx handler (cosmos#21979) * fix testdata in autocli msg tests * fix ABCI tests broken by CheckTxHandler PR (cosmos#21979) * fix broken tests in x/bank introduced by 59f4bfe * * Fix errors in store tests introduced by 5c206aa which adds new commitSync bool and is never tested * Fix building errors in integration tests introduced by f173a77 which breaks all integration tests using the bank keeper * Remove deprecated MsgEditValidator ValidateBasic function which was breaking some related CLI test in x/staking * fix(baseapp): return events from preblocker in FinalizeBlockResponse (cosmos#21159) * * Fix ante tests in x/auth broken by c053612 * Update base block gas in block gas tests * * Update GH worfklow to work with Go 1.23.5 * Add missing bank module to simapp's EndBlockers causing test-simapp to fail in GH workflow * remove unwanted file addition * Fix E2E tests that were failing in majority due to changes in BroadcastTxSync in Comet V1 * bump cosmos-db to v1.0.1 * run go mod tidy for all submodules * chore: update cometbft to v1.0.1-inj exact tag. refresh go.mod and go.sum dependencies. * chore: post-rebase code patches * missing merge in auth * gogoproto extension double-reg issue * grpc/pulsar re-generated (Note: missed that during #53) * minimise diff to only cometbft1 related changes * fix preblocker events (keep old behavior) * fix store tests --------- Co-authored-by: Simon Noetzlin <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Jeancarlo Barrios <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Marko <[email protected]> Co-authored-by: Facundo Medica <[email protected]>

missed bytes field type in makeGetSignersFunc for EVM originating signatures

…tor.SelectTxForProposal (cosmos#24074) Co-authored-by: Alex | Interchain Labs <[email protected]>

Also fix a bug in the signer tests left from b504681

[CP-379] backport sdk patch

Also adjust the tests to reflect the new behavior and re-gen mocks.

Signed-off-by: Nikola Marcetic <[email protected]>

coderabbitai · 2025-05-26T15:26:41Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch CP-349/testnetify-valset

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-26T00:22:37Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

…utomation of errors documentation generation

…istered_errors [CP-405] add accessor all registered errors

github-actions · 2025-08-01T00:27:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

* chore: added a Makefile action to assist in the tag process for subfolders * [CHORE] Added a Makefile action to generate the correct tag for the `client` subdir

github-actions · 2025-10-03T00:20:14Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

maxim-inj and others added 11 commits May 4, 2025 15:20

fix: x/tx/signing: support bytes field in signer

ed3a460

missed bytes field type in makeGetSignersFunc for EVM originating signatures

fix: x/tx/signing: support bytes field in signer

a0fa693

missed bytes field type in makeGetSignersFunc for EVM originating signatures

fix(baseapp): Use CometBFT's ComputeProtoSizeForTxs in defaultTxSelec…

4f1f395

…tor.SelectTxForProposal (cosmos#24074) Co-authored-by: Alex | Interchain Labs <[email protected]>

CP-379/backport-sdk-patch chore: fix tests

05861dd

Also fix a bug in the signer tests left from b504681

Merge pull request #58 from InjectiveLabs/CP-379/backport-sdk-patch

c43a2ea

[CP-379] backport sdk patch

CP-390 disable DepositValidatorRewardsPool for non-staking tokens

4f1ecc4

Also adjust the tests to reflect the new behavior and re-gen mocks.

WIP

5e94ca5

Signed-off-by: Nikola Marcetic <[email protected]>

Merge conflicts with v0.50.x-evm-comet1-inj

24500ad

Signed-off-by: Nikola Marcetic <[email protected]>

chore: bump cometbft to v1.0.1-inj.2

4061264

minor refactoring

6c20db7

Signed-off-by: Nikola Marcetic <[email protected]>

nmarcetic requested review from kakysha and maxim-inj May 26, 2025 15:26

github-actions bot added the Stale label Jun 26, 2025

github-actions bot closed this Jun 30, 2025

maxim-inj reopened this Jun 30, 2025

github-actions bot removed the Stale label Jul 1, 2025

aarmoa added 2 commits July 8, 2025 16:57

[CP-405] Added logic to access all registered errors, to aid in the a…

1bda6ce

…utomation of errors documentation generation

Merge pull request #61 from InjectiveLabs/cp-405/add_accessor_all_reg…

1753ce6

…istered_errors [CP-405] add accessor all registered errors

github-actions bot added the Stale label Aug 1, 2025

chore/add_tagging_script (#62)

ac26c4b

* chore: added a Makefile action to assist in the tag process for subfolders * [CHORE] Added a Makefile action to generate the correct tag for the `client` subdir

github-actions bot closed this Aug 6, 2025

maxim-inj reopened this Aug 28, 2025

github-actions bot removed the Stale label Aug 29, 2025

maxim-inj added 2 commits September 2, 2025 09:41

Merge branch 'v0.50.x-inj' into CP-349/testnetify-valset

6b9b387

chore: cleanup go.sum files post-merge

905110f

github-actions bot added the C:x/staking label Sep 2, 2025

github-actions bot added C:x/feegrant C:x/tx C:Store C:x/circuit C:x/distribution C:x/evidence C:x/nft C:x/upgrade Type: Build labels Sep 2, 2025

github-actions bot added the Stale label Oct 3, 2025

github-actions bot closed this Oct 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CP-349] Extends Testnetify to support multi valset #60

[CP-349] Extends Testnetify to support multi valset #60

Uh oh!

nmarcetic commented May 26, 2025

Uh oh!

coderabbitai bot commented May 26, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

github-actions bot commented Jun 26, 2025

Uh oh!

github-actions bot commented Aug 1, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[CP-349] Extends Testnetify to support multi valset #60

[CP-349] Extends Testnetify to support multi valset #60

Uh oh!

Conversation

nmarcetic commented May 26, 2025

Description

Author Checklist

Reviewers Checklist

Uh oh!

coderabbitai bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

github-actions bot commented Jun 26, 2025

Uh oh!

github-actions bot commented Aug 1, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented May 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)