[diff] v0.50.x-storefix-inj -> v0.50.x-inj #63

maxim-inj · 2025-08-01T10:08:54Z

Rollback to vanilla CosmosSDK/store from v0.50.13,
had to keep async pruning patch because:

a) it's already applied
b) it's easy to keep disabled
c) it had IAVL bumped and I don't want to rollback IAVL dependency version.

coderabbitai · 2025-08-01T10:09:01Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch v0.50.x-storefix-inj

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

socket-security · 2025-08-01T10:15:37Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Vulnerability
github.com/cosmos/cosmos-sdk@v0.46.0-beta2.0.20230614103911-b3da8bb4e801 ⏵ v0.50.6	⁺¹
github.com/cosmos/cosmos-sdk@v0.46.0-beta2.0.20230614103911-b3da8bb4e801 ⏵ v0.50.8	⁺¹
github.com/InjectiveLabs/cometbft@v1.0.1-inj.3
google.golang.org/grpc@v1.53.0 ⏵ v1.71.0	⁺¹	⁺¹⁸
google.golang.org/protobuf@v1.29.1 ⏵ v1.36.5	⁺¹	⁺²
cosmossdk.io/api@v0.7.5 ⏵ v0.7.6
google.golang.org/genproto/googleapis/api@v0.0.0-20240227224415-6ceb2ff114de ⏵ v0.0.0-20250106144421-5f5ef82da422	⁺¹
cosmossdk.io/depinject@v1.0.0-alpha.4 ⏵ v1.1.0	^-3
github.com/spf13/cobra@v1.8.0 ⏵ v1.9.1	^-1
github.com/stretchr/testify@v1.8.4 ⏵ v1.10.0	⁺³
cosmossdk.io/store@v1.0.0 ⏵ v1.1.1	⁺¹
cosmossdk.io/x/upgrade@v0.0.0-20230614103911-b3da8bb4e801 ⏵ v0.1.4
cosmossdk.io/client/v2@v2.0.0-beta.5.0.20241121152743-3dad36d9a29e
cosmossdk.io/x/nft@v0.1.1
cosmossdk.io/x/evidence@v0.1.1
cosmossdk.io/x/feegrant@v0.1.1
cosmossdk.io/core@v0.11.1
cosmossdk.io/x/circuit@v0.1.1
cosmossdk.io/tools/confix@v0.1.1
github.com/InjectiveLabs/cometbft/api@v1.0.0-inj.2
cosmossdk.io/math@v1.3.0 ⏵ v1.4.0	⁺¹	⁺¹⁶

View full report

socket-security · 2025-08-01T10:15:38Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		`github.com/gofiber/fiber/[email protected]` has a Critical CVE. CVE: GHSA-fmg4-x8pw-hjhg Fiber has Insecure CORS Configuration, Allowing Wildcard Origin with Credentials (CRITICAL) Affected versions: < 2.52.1 Patched version: 2.52.1 From: `?` → `golang/github.com/gofiber/fiber/[email protected]` ℹ Read more on: This package \| This alert \| What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore golang/github.com/gofiber/fiber/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		`github.com/gofiber/fiber/[email protected]` has a Critical CVE. CVE: GHSA-98j2-3j3p-fw2v Session Middleware Token Injection Vulnerability (CRITICAL) Affected versions: < 2.52.5 Patched version: 2.52.5 From: `?` → `golang/github.com/gofiber/fiber/[email protected]` ℹ Read more on: This package \| This alert \| What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore golang/github.com/gofiber/fiber/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		`github.com/nats-io/nats-server/[email protected]` has a Critical CVE. CVE: GHSA-4w5x-x539-ppf5 Incorrect handling of credential expiry by /nats-io/nats-server (CRITICAL) Affected versions: < 2.1.9 Patched version: 2.1.9 From: `?` → `golang/github.com/nats-io/nats-server/[email protected]` ℹ Read more on: This package \| This alert \| What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore golang/github.com/nats-io/nats-server/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

kakysha · 2025-08-01T14:48:26Z

store/rootmulti/store.go

 		panic("recursive MultiStores not yet supported")

 	case types.StoreTypeIAVL:
-		store, err := iavl.LoadStoreWithOpts(db, rs.logger, key, id, params.initialVersion, rs.iavlCacheSize, rs.iavlDisableFastNode, rs.metrics, iavltree.AsyncPruningOption(!rs.iavlSyncPruning))


aren't we losing the ability tocustomize async pruning by getting rid of iavl.LoadStoreWithOpts() here?

that looks like a typo o_O

Hard to tell btw, I just used vanilla store/ but I see this part is really different. Need to investigate the changes around async pruning.

xlab · 2025-08-01T15:19:23Z

Regarding branch: it's ready and I did tags to test the rest, once we're done with chain stuff, I'll make sure to iron out latest diffs and we'll make another set of tags.

Do not merge :)

github-actions · 2025-09-01T00:26:25Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

maxim-inj and others added 6 commits August 1, 2025 00:18

chore: bump cometbft to v1.0.1-inj.3

af0f680

chore: rollback to vanilla cosmos-sdk/v0.50.13/store.

8f117de

chore: adapt store to cometbft v1.0.1

cc3c3f3

chore: get rid of objectstore

c1b328d

feat(store): async pruning iavl

d7cf3b6

#52

fix(bank): remove objStoreKey traces

8ddfbbd

maxim-inj requested a review from kakysha August 1, 2025 10:08

github-actions bot added C:x/bank C:CLI C:x/feegrant C:x/gov C:Store C:Confix C:x/circuit C:x/evidence C:x/nft C:x/upgrade labels Aug 1, 2025

kakysha approved these changes Aug 1, 2025

View reviewed changes

github-actions bot added the Stale label Sep 1, 2025

github-actions bot closed this Sep 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[diff] v0.50.x-storefix-inj -> v0.50.x-inj #63

[diff] v0.50.x-storefix-inj -> v0.50.x-inj #63

Uh oh!

maxim-inj commented Aug 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 1, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

socket-security bot commented Aug 1, 2025

Uh oh!

socket-security bot commented Aug 1, 2025

Uh oh!

kakysha Aug 1, 2025

Uh oh!

xlab Aug 1, 2025

Uh oh!

xlab Aug 1, 2025

Uh oh!

xlab commented Aug 1, 2025

Uh oh!

github-actions bot commented Sep 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[diff] v0.50.x-storefix-inj -> v0.50.x-inj #63

[diff] v0.50.x-storefix-inj -> v0.50.x-inj #63

Uh oh!

Conversation

maxim-inj commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Aug 1, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

socket-security bot commented Aug 1, 2025

Uh oh!

socket-security bot commented Aug 1, 2025

Uh oh!

kakysha Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

xlab Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

xlab Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

xlab commented Aug 1, 2025

Uh oh!

github-actions bot commented Sep 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

maxim-inj commented Aug 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)