Feat/update to 1.16.3 #259
Conversation
WalkthroughThe workspace narrows to contracts only. Multiple Cargo.toml files switch from workspace-managed dependencies to explicit pinned versions, apply version bumps across CosmWasm and Injective crates, remove a dev tool, and add optimized release profiles to select packages. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (8)
Cargo.toml (2)
14-15: Align CosmWasm crate versions to avoid duplicate builds and feature skewRoot workspace uses cosmwasm-std = 2.2.0 and cw-multi-test = 2.2.0, while packages pin 2.2.2 (std) and 2.2.1 (multi-test). This can pull multiple versions into the graph and cause feature mismatches. Recommend aligning all to a single version.
Suggested change (root manifest) to match the latest pins used downstream:
- cosmwasm-std = { version = "2.2.0", features = [ "abort", "cosmwasm_1_2", "cosmwasm_1_3", "cosmwasm_1_4", "cosmwasm_2_0", "iterator", "stargate" ] } - cw-multi-test = { version = "2.2.0" } + cosmwasm-std = { version = "2.2.2", features = [ "abort", "cosmwasm_1_2", "cosmwasm_1_3", "cosmwasm_1_4", "cosmwasm_2_0", "iterator", "stargate" ] } + cw-multi-test = { version = "2.2.2" }Note: This also requires bumping cw-multi-test in packages/injective-testing to 2.2.2 (see comment in that file).
5-8: Redundant profile overrides: duplicated with the crate’s own [profile.release]You set [profile.release.package.injective-cosmwasm] here, and packages/injective-cosmwasm also defines its own [profile.release] with identical values. The workspace override will take precedence for builds from this workspace; the crate’s local profile applies when built outside this workspace. If you aim to keep all knobs centralized, consider dropping one to reduce confusion.
packages/injective-testing/Cargo.toml (2)
13-13: Unify cw-multi-test version with workspaceRoot is proposed to use cw-multi-test 2.2.2 to avoid duplicates. Please align this crate accordingly.
- cw-multi-test = { version = "2.2.1" } + cw-multi-test = { version = "2.2.2" }
12-12: cosmwasm-std version alignmentThis crate pins 2.2.2 while the root has 2.2.0. I suggested bumping the root to 2.2.2 to match here and in other packages to avoid duplicate versions.
packages/injective-cosmwasm/Cargo.toml (4)
2-2: Normalize authors formatting for consistencyThe authors field mixes formats across crates. Prefer the standard “Name ” format used elsewhere in the repo.
- authors = [ "Albert Chon [email protected]", "F Grabner [email protected]", "Markus Waas [email protected]", "Jose Luis [email protected]" ] + authors = [ + "Albert Chon <[email protected]>", + "F Grabner <[email protected]>", + "Markus Waas <[email protected]>", + "Jose Luis <[email protected]>" + ]
12-12: cosmwasm-std version alignment with workspaceThis crate uses 2.2.2; root currently pins 2.2.0. I suggested bumping the root to 2.2.2 to avoid pulling multiple versions.
22-22: Prefer explicit no-std posture for ed25519-zebraIf this crate or its dependents are compiled to Wasm targets in no_std contexts, it’s safer to disable default features and enable only alloc.
- ed25519-zebra = { version = "4.1.0", features = ["alloc"] } + ed25519-zebra = { version = "4.1.0", default-features = false, features = ["alloc"] }If you intentionally rely on std here, feel free to ignore.
29-39: Release profile duplication with workspace overridesThis crate defines [profile.release], while the workspace root defines [profile.release.package.injective-cosmwasm] with the same values. For builds from the workspace, the root override will win; this local profile only matters when building the crate outside the workspace. Keeping both is fine; consider removing one to reduce duplication.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
Cargo.toml(2 hunks)packages/injective-cosmwasm/Cargo.toml(1 hunks)packages/injective-math/Cargo.toml(1 hunks)packages/injective-testing/Cargo.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Lints
- GitHub Check: Lints
🔇 Additional comments (7)
Cargo.toml (2)
2-2: Confirm intent to narrow workspace to contracts onlyDropping packages/* from members changes how profiles, publishing, and [patch.crates-io] overrides apply. It looks intentional given the per-crate pins, but please confirm this is the desired long-term structure (local packages become external dependencies rather than workspace members).
Would you like me to scan the repo for any cargo commands, CI jobs, or docs that still assume packages/* are workspace members?
24-24: Path + version for injective-testing is good; verify intent for othersinjective-testing references a local path (with a version), ensuring you use the local crate. injective-cosmwasm and injective-math are version-only (no path), so the workspace will pull from crates.io even though local copies exist under packages/. Confirm that’s intentional.
packages/injective-testing/Cargo.toml (1)
8-8: Version bump looks goodThe crate version bump to 1.1.12-1 is consistent with the broader Injective stack updates (1.16.3-1).
packages/injective-cosmwasm/Cargo.toml (1)
9-9: Version update LGTMVersion bump to 0.3.4-1 aligns with dependent crates in the workspace and external releases.
packages/injective-math/Cargo.toml (3)
9-9: Version update LGTM0.3.4-1 matches the overall dependency updates.
14-17: Pinned dependencies and features look consistentPins for cosmwasm-std 2.2.2 and serde/schemars/primitive-types are consistent with the rest of the stack.
19-29: Release profile matches the project-wide optimization settingsThe profile settings align with the other crates. No issues.
Summary by CodeRabbit