Feat/remove deprecated pre commit repo #290
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| name: golangci-lint | ||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [master, dev] | ||
| permissions: | ||
| contents: read | ||
| # Optional: allow read access to pull request. Use with `only-new-issues` option. | ||
| pull-requests: read | ||
|
|
||
| jobs: | ||
| golangci: | ||
| name: lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: "go.mod" | ||
| check-latest: true | ||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v6 | ||
| with: | ||
| # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version | ||
| version: latest | ||
|
|
||
| # Optional: working directory, useful for monorepos | ||
| # working-directory: somedir | ||
|
|
||
| # Optional: golangci-lint command line arguments. | ||
| args: --timeout=15m -v | ||
|
|
||
| # Optional: show only new issues if it's a pull request. The default value is `false`. | ||
| only-new-issues: false | ||
|
|
||
| # Optional: if set to true then the all caching functionality will be complete disabled, | ||
| # takes precedence over all other caching options. | ||
| # skip-cache: true | ||
|
|
||
| # Optional: if set to true then the action don't cache or restore ~/go/pkg. | ||
| skip-cache: true | ||
|
|
||
| # Optional: if set to true then the action don't cache or restore ~/.cache/go-build. | ||
| # skip-build-cache: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,14 +8,11 @@ jobs: | |
| pre-commit: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainVerify the checkout action version. The 🌐 Web query: 💡 Result: The latest stable version of the For most workflows, you can implement it with: - uses: actions/checkout@v4Key updates in recent versions:
Always check the official repository for new releases, as GitHub periodically updates actions to maintain compatibility with platform changes[6]. Citations:
Action Required: Update GitHub Checkout Action Version File: The workflow currently uses: - uses: actions/checkout@v3Based on the latest information, the current stable version of the checkout action is v4. This update addresses Node.js compatibility (switching to Node.js 20), improves security practices, and enhances overall reliability. Please update the workflow step to: - uses: actions/checkout@v4🧰 Tools🪛 actionlint (1.7.4)11-11: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue (action) |
||
| with: | ||
| fetch-depth: 2 | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: "go.mod" | ||
| check-latest: true | ||
| - uses: pre-commit/[email protected] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,54 +1,48 @@ | ||
| run: | ||
| tests: false | ||
| skip-dirs: | ||
| - chain | ||
| - exchange | ||
| - injective_data | ||
| - proto | ||
|
|
||
| linters: | ||
| fast: false | ||
| enable: | ||
| - errcheck | ||
| - errorlint | ||
| - gas | ||
| - gocritic | ||
| - gofmt | ||
| - goimports | ||
| - gosimple | ||
| - govet | ||
| - ineffassign | ||
| - megacheck | ||
| - misspell | ||
| - nakedret | ||
| - prealloc | ||
| - revive | ||
| - staticcheck | ||
| - unconvert | ||
| - unparam | ||
| disable: | ||
| - unused | ||
|
|
||
| linters-settings: | ||
| revive: | ||
| enableAllRules: true | ||
| rules: | ||
| - name: var-naming | ||
| arguments: | ||
| - ["ID"] | ||
| gocritic: | ||
| enabled-tags: | ||
| - diagnostic | ||
| - experimental | ||
| - opinionated | ||
| - performance | ||
| - style | ||
| disabled-checks: | ||
| - hugeParam | ||
| - unnamedResult |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,10 +13,3 @@ repos: | |
| - id: end-of-file-fixer | ||
| - id: end-of-file-fixer | ||
| - id: check-yaml | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Update checkout action to latest version.
The
actions/checkoutaction should be updated to v4 for better compatibility and security.Apply this diff:
📝 Committable suggestion
🧰 Tools
🪛 actionlint (1.7.4)
16-16: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)