Skip to content

Feat/rework menu #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andrea-kyurchiev
Copy link
Collaborator

@andrea-kyurchiev andrea-kyurchiev commented Jul 2, 2025

I've adjusted the menu to look as described by @clcoffey
A couple of things to keep in mind with the new structure:

  • Row titles (previously "Main" and "Additional Information" will only show if there is a secondary row
  • The secondary row now shows up only if items in it exist so it is no longer linked to a range of 5 items
  • isSecondary must be set for any menu items that should appear in the "secondary row" on the right hand side
  • in case a secondary row needs to be added to the existing menu both mainTitle and secondaryColumnTitle must be set. This allows us to set them to reflect the menu items instead of the generic "Main" and "Additional Information" . We could also put these back in as defaults but we will need an additional flag (ex. hasSecondaryRow) for example.
  • @clcoffey in the issue Code Of Conduct was present in both "About" and "Community" this actually breaks and it appears only under one. I have left it under "Community" for now but I can move it to the "About" menu instead if needed

Closes #1047

There were no translated menu items in the files so just copy pasted from the EN file
@rrrutledge
Copy link
Contributor

I think that @clcoffey is otherwise occupied for now, but she may get to this later in the month

@clcoffey
Copy link
Collaborator

clcoffey commented Jul 25, 2025

I appologise for the delay. Thank you for working on this @andrea-kyurchiev I think it looks better and for now should work. I am guessing the width of the menu is not adjustable and we are not able to use different menu widths across different menu sections.

@andrea-kyurchiev
Copy link
Collaborator Author

@clcoffey we can certainly adjust the widths although it will be very hard to make it remain responsive with different widths. But we can add margins/paddings if any items need it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main Navigation Menu Update
3 participants