Skip to content

Conversation

@Shalmezad
Copy link
Contributor

@Shalmezad Shalmezad commented Aug 18, 2025

Looking to start contributing to this repository, noticed there were some existing unit tests that currently aren't being checked in the CI pipeline. This PR adds a workflow step to run them.

This also updates the runner for the amd64 build to be amd64 based, avoiding the need for installing a specific version of gcc and avoiding an issue with reqwest/openssl

@Speykious
Copy link
Member

I think it would be better as a step after the build though. That way we avoid building the same thing twice and we also test on all targets.

@Shalmezad
Copy link
Contributor Author

I think it would be better as a step after the build though. That way we avoid building the same thing twice and we also test on all targets.

Can do. Give me a couple minutes to make an amend commit

@Shalmezad Shalmezad marked this pull request as draft August 19, 2025 00:40
@Shalmezad Shalmezad marked this pull request as ready for review August 19, 2025 00:55
@Speykious Speykious merged commit afa880a into Inochi2D:main Aug 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants