WIP #11

Insality · 2025-08-26T16:07:43Z

No description provided.

Copilot

Pull Request Overview

This PR adds a debug interface for the saver module with improved file handling and variable scoping. The changes focus on creating a properties panel for debugging save/load operations and fixing file path handling.

Adds a new debug properties panel with save/load slot management and inspection capabilities
Fixes file mode and variable scoping issues in the saver internal module
Simplifies file path handling by flattening directory structures

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
saver/saver_internal.lua	Updates file modes from "w+" to "wb" and fixes variable scoping for LUA_REQUIRE_AS_STRING
saver/saver_debug_page.lua	New debug interface providing save/load slot management and game state inspection
saver/saver.lua	Integrates debug panel, adds autosave timer getter, and simplifies file path handling
saver/properties_panel/property_saver_slots.lua	Widget implementation for three-button slot interface
saver/properties_panel/property_saver_slots.gui	GUI definition for the slot selection widget

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-26T16:09:32Z

saver/saver.lua

 	end

-	return sys.get_save_file(directory_path, filename)
+	filename = filename:gsub("/", "_")


This change breaks subfolder support by converting directory separators to underscores. Files that were previously saved in subfolders (e.g., "profiles/profile1.json") will now be flattened to a single directory with underscore-separated names (e.g., "profiles_profile1.json"). This creates a breaking change where existing save files in subfolders become inaccessible.

Suggested change

filename = filename:gsub("/", "_")

-- filename = filename:gsub("/", "_")

Copilot · 2025-08-26T16:09:33Z

saver/saver_debug_page.lua

+			saver.load_game_state("saver_slot_1")
+			sys.reboot("--config=saver.save_name=saver_slot_1", "--config=saver.autosave_timer=0")
+		end)
+		three_buttons.button_2.on_click:subscribe(function()
+			saver.load_game_state("saver_slot_2")
+			sys.reboot("--config=saver.save_name=saver_slot_2", "--config=saver.autosave_timer=0")
+		end)
+		three_buttons.button_3.on_click:subscribe(function()
+			saver.load_game_state("saver_slot_3")
+			sys.reboot("--config=saver.save_name=saver_slot_3", "--config=saver.autosave_timer=0")


The sys.reboot calls with hardcoded configuration parameters could potentially be exploited if user input influences the slot names. Consider validating that slot names contain only safe characters before passing them to sys.reboot.

Suggested change

saver.load_game_state("saver_slot_1")

sys.reboot("--config=saver.save_name=saver_slot_1", "--config=saver.autosave_timer=0")

end)

three_buttons.button_2.on_click:subscribe(function()

saver.load_game_state("saver_slot_2")

sys.reboot("--config=saver.save_name=saver_slot_2", "--config=saver.autosave_timer=0")

end)

three_buttons.button_3.on_click:subscribe(function()

saver.load_game_state("saver_slot_3")

sys.reboot("--config=saver.save_name=saver_slot_3", "--config=saver.autosave_timer=0")

local slot_name = "saver_slot_1"

saver.load_game_state(slot_name)

if validate_slot_name(slot_name) then

sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")

else

print("Invalid slot name: " .. tostring(slot_name))

end

end)

three_buttons.button_2.on_click:subscribe(function()

local slot_name = "saver_slot_2"

saver.load_game_state(slot_name)

if validate_slot_name(slot_name) then

sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")

else

print("Invalid slot name: " .. tostring(slot_name))

end

end)

three_buttons.button_3.on_click:subscribe(function()

local slot_name = "saver_slot_3"

saver.load_game_state(slot_name)

if validate_slot_name(slot_name) then

sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")

else

print("Invalid slot name: " .. tostring(slot_name))

end

Copilot · 2025-08-26T16:09:33Z

saver/saver_debug_page.lua

+			saver.load_game_state("saver_slot_1")
+			sys.reboot("--config=saver.save_name=saver_slot_1", "--config=saver.autosave_timer=0")
+		end)
+		three_buttons.button_2.on_click:subscribe(function()
+			saver.load_game_state("saver_slot_2")
+			sys.reboot("--config=saver.save_name=saver_slot_2", "--config=saver.autosave_timer=0")
+		end)
+		three_buttons.button_3.on_click:subscribe(function()
+			saver.load_game_state("saver_slot_3")
+			sys.reboot("--config=saver.save_name=saver_slot_3", "--config=saver.autosave_timer=0")


The sys.reboot calls with hardcoded configuration parameters could potentially be exploited if user input influences the slot names. Consider validating that slot names contain only safe characters before passing them to sys.reboot.

Suggested change

saver.load_game_state("saver_slot_1")

sys.reboot("--config=saver.save_name=saver_slot_1", "--config=saver.autosave_timer=0")

end)

three_buttons.button_2.on_click:subscribe(function()

saver.load_game_state("saver_slot_2")

sys.reboot("--config=saver.save_name=saver_slot_2", "--config=saver.autosave_timer=0")

end)

three_buttons.button_3.on_click:subscribe(function()

saver.load_game_state("saver_slot_3")

sys.reboot("--config=saver.save_name=saver_slot_3", "--config=saver.autosave_timer=0")

local slot_name = "saver_slot_1"

saver.load_game_state(slot_name)

if is_valid_slot_name(slot_name) then

sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")

else

print("Invalid slot name: " .. tostring(slot_name))

end

end)

three_buttons.button_2.on_click:subscribe(function()

local slot_name = "saver_slot_2"

saver.load_game_state(slot_name)

if is_valid_slot_name(slot_name) then

sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")

else

print("Invalid slot name: " .. tostring(slot_name))

end

end)

three_buttons.button_3.on_click:subscribe(function()

local slot_name = "saver_slot_3"

saver.load_game_state(slot_name)

if is_valid_slot_name(slot_name) then

sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")

else

print("Invalid slot name: " .. tostring(slot_name))

end

Copilot · 2025-08-26T16:09:33Z

saver/saver_debug_page.lua

+			saver.load_game_state("saver_slot_1")
+			sys.reboot("--config=saver.save_name=saver_slot_1", "--config=saver.autosave_timer=0")
+		end)
+		three_buttons.button_2.on_click:subscribe(function()
+			saver.load_game_state("saver_slot_2")
+			sys.reboot("--config=saver.save_name=saver_slot_2", "--config=saver.autosave_timer=0")
+		end)
+		three_buttons.button_3.on_click:subscribe(function()
+			saver.load_game_state("saver_slot_3")
+			sys.reboot("--config=saver.save_name=saver_slot_3", "--config=saver.autosave_timer=0")


The sys.reboot calls with hardcoded configuration parameters could potentially be exploited if user input influences the slot names. Consider validating that slot names contain only safe characters before passing them to sys.reboot.

Suggested change

saver.load_game_state("saver_slot_1")

sys.reboot("--config=saver.save_name=saver_slot_1", "--config=saver.autosave_timer=0")

end)

three_buttons.button_2.on_click:subscribe(function()

saver.load_game_state("saver_slot_2")

sys.reboot("--config=saver.save_name=saver_slot_2", "--config=saver.autosave_timer=0")

end)

three_buttons.button_3.on_click:subscribe(function()

saver.load_game_state("saver_slot_3")

sys.reboot("--config=saver.save_name=saver_slot_3", "--config=saver.autosave_timer=0")

local slot_name = "saver_slot_1"

saver.load_game_state(slot_name)

if is_valid_slot_name(slot_name) then

sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")

else

print("Invalid slot name: " .. tostring(slot_name))

end

end)

three_buttons.button_2.on_click:subscribe(function()

local slot_name = "saver_slot_2"

saver.load_game_state(slot_name)

if is_valid_slot_name(slot_name) then

sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")

else

print("Invalid slot name: " .. tostring(slot_name))

end

end)

three_buttons.button_3.on_click:subscribe(function()

local slot_name = "saver_slot_3"

saver.load_game_state(slot_name)

if is_valid_slot_name(slot_name) then

sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")

else

print("Invalid slot name: " .. tostring(slot_name))

end

Copilot · 2025-08-26T16:09:34Z

saver/saver_debug_page.lua

+	if system == "Windows" then
+		os.execute(string.format('explorer /select,"%s"', path))


The os.execute calls with user-provided paths could be vulnerable to command injection if the path contains malicious characters. Consider sanitizing the path parameter or using a safer alternative to os.execute for opening file browsers.

Suggested change

if system == "Windows" then

os.execute(string.format('explorer /select,"%s"', path))

-- Helper to safely quote Windows paths

local function windows_quote(str)

-- Escape double quotes and wrap in quotes

return '"' .. tostring(str):gsub('"', '\\"') .. '"'

end

if system == "Windows" then

os.execute(string.format('explorer /select,%s', windows_quote(path)))

Copilot · 2025-08-26T16:09:34Z

saver/saver_debug_page.lua

+		os.execute(string.format('explorer /select,"%s"', path))
+		return true
+	elseif system == "Linux" then
+		os.execute(string.format("xdg-open %q", path))


The os.execute calls with user-provided paths could be vulnerable to command injection if the path contains malicious characters. Consider sanitizing the path parameter or using a safer alternative to os.execute for opening file browsers.

Copilot · 2025-08-26T16:09:34Z

saver/saver_debug_page.lua

+		os.execute(string.format("xdg-open %q", path))
+		return true
+	elseif system == "Darwin" then
+		os.execute(string.format("open -R %q", path))


The os.execute calls with user-provided paths could be vulnerable to command injection if the path contains malicious characters. Consider sanitizing the path parameter or using a safer alternative to os.execute for opening file browsers.

codecov · 2025-10-26T17:43:02Z

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.57%. Comparing base (cf00144) to head (13fc247).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
saver/saver.lua	70.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   78.43%   76.57%   -1.87%     
==========================================
  Files           4        4              
  Lines         524      525       +1     
==========================================
- Hits          411      402       -9     
- Misses        113      123      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Insality added 14 commits May 17, 2025 13:33

Add saber debug panel

42bcbaf

Update

fb775d5

Fix for lua require as string

1eac359

Merge branch 'debug_panel' into develop

245dfdc

Remove druid color from debug panels

6b6d224

Update subfolders for windows paths

38a1c6c

Fix for windows \r lines

f88417d

Fix for window paths again

ecc51bd

The get_save_path() without arguments now returns a app folder

188eae4

Update saver debug panel

ba3b352

Update log

f5856cc

Fix reboot

7d9f2d4

Update subfolders

575999f

Remove subfolder support due it not working well currently

c78c6f8

Copilot AI review requested due to automatic review settings August 26, 2025 16:07

Copilot AI reviewed Aug 26, 2025

View reviewed changes

Insality changed the title ~~WIP Release~~ WIP Aug 26, 2025

Update properties panel

13fc247

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

WIP #11

WIP #11

Uh oh!

Insality commented Aug 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 26, 2025

Uh oh!

Copilot AI Aug 26, 2025

Uh oh!

Copilot AI Aug 26, 2025

Uh oh!

Copilot AI Aug 26, 2025

Uh oh!

Copilot AI Aug 26, 2025

Uh oh!

Copilot AI Aug 26, 2025

Uh oh!

Copilot AI Aug 26, 2025

Uh oh!

codecov bot commented Oct 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	filename = filename:gsub("/", "_")
	-- filename = filename:gsub("/", "_")

-			saver.load_game_state("saver_slot_1")
-			sys.reboot("--config=saver.save_name=saver_slot_1", "--config=saver.autosave_timer=0")
-		end)
-		three_buttons.button_2.on_click:subscribe(function()
-			saver.load_game_state("saver_slot_2")
-			sys.reboot("--config=saver.save_name=saver_slot_2", "--config=saver.autosave_timer=0")
-		end)
-		three_buttons.button_3.on_click:subscribe(function()
-			saver.load_game_state("saver_slot_3")
-			sys.reboot("--config=saver.save_name=saver_slot_3", "--config=saver.autosave_timer=0")
+			local slot_name = "saver_slot_1"
+			saver.load_game_state(slot_name)
+			if validate_slot_name(slot_name) then
+				sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")
+			else
+				print("Invalid slot name: " .. tostring(slot_name))
+			end
+		end)
+		three_buttons.button_2.on_click:subscribe(function()
+			local slot_name = "saver_slot_2"
+			saver.load_game_state(slot_name)
+			if validate_slot_name(slot_name) then
+				sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")
+			else
+				print("Invalid slot name: " .. tostring(slot_name))
+			end
+		end)
+		three_buttons.button_3.on_click:subscribe(function()
+			local slot_name = "saver_slot_3"
+			saver.load_game_state(slot_name)
+			if validate_slot_name(slot_name) then
+				sys.reboot("--config=saver.save_name=" .. slot_name, "--config=saver.autosave_timer=0")
+			else
+				print("Invalid slot name: " .. tostring(slot_name))
+			end

		if system == "Windows" then
		os.execute(string.format('explorer /select,"%s"', path))

-	if system == "Windows" then
-		os.execute(string.format('explorer /select,"%s"', path))
+	-- Helper to safely quote Windows paths
+	local function windows_quote(str)
+		-- Escape double quotes and wrap in quotes
+		return '"' .. tostring(str):gsub('"', '\\"') .. '"'
+	end
+	if system == "Windows" then
+		os.execute(string.format('explorer /select,%s', windows_quote(path)))

Uh oh!

WIP #11

Are you sure you want to change the base?

WIP #11

Uh oh!

Conversation

Insality commented Aug 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 26, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants