Skip to content

Raw lunatic XML & JSON data saving into database #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexisszmundy merged 14 commits into from
Dec 18, 2024
Merged

Raw lunatic XML & JSON data saving into database #139

alexisszmundy merged 14 commits into from
Dec 18, 2024

Conversation

@alexisszmundy
Copy link
Contributor

@alexisszmundy alexisszmundy commented Dec 5, 2024

No description provided.

alexisszmundy
alexisszmundy commented Dec 5, 2024
View reviewed changes
src/main/java/fr/insee/genesis/infrastructure/document/rawdata/xml/LunaticXmlDataDocument.java
@Id
private ObjectId id;
private LunaticXmlCampaign lunaticXmlData;
private Mode mode;
Copy link
Contributor Author

@alexisszmundy alexisszmundy Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas sûr de stocker ça en base, mais je l'ai mis au cas où

nsenave
nsenave reviewed Dec 5, 2024
View reviewed changes
Copy link

@nsenave nsenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Des remarques/propositions sur la forme

@alexisszmundy alexisszmundy changed the title Raw lunatic XML data saving into database Raw lunatic XML & JSON data saving into database Dec 6, 2024
nsenave
nsenave reviewed Dec 6, 2024
View reviewed changes
Copy link

@nsenave nsenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nsenave
Copy link

nsenave commented Dec 6, 2024

Ah sry @alexisszmundy j'ai eu une notif sur 1fbdcc5 et pas sur le revert. My bad si les autowired sont nécessaires ici.

Je fais un peu croisade contre cette annotation côté controller, mais côté service elle semble assez bien justifiée pour définir l'injection à choisir par défaut en injection de dépendance/inversion de contrôle

@alexisszmundy
Copy link
Contributor Author

alexisszmundy commented Dec 10, 2024

Ah sry @alexisszmundy j'ai eu une notif sur 1fbdcc5 et pas sur le revert. My bad si les autowired sont nécessaires ici.

Je fais un peu croisade contre cette annotation côté controller, mais côté service elle semble assez bien justifiée pour définir l'injection à choisir par défaut en injection de dépendance/inversion de contrôle

Effectivement sur les controllers j'arrive à les retirer sans problème

nsenave
nsenave reviewed Dec 10, 2024
View reviewed changes
Copy link

@nsenave nsenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@alexisszmundy alexisszmundy merged commit 1685ab3 into main Dec 18, 2024
4 checks passed
nsenave
nsenave reviewed Dec 18, 2024
View reviewed changes
Copy link

@nsenave nsenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relu et ras

@alexisszmundy alexisszmundy deleted the devRawDataSave branch January 23, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alicela alicela Awaiting requested review from alicela

@loichenninger loichenninger Awaiting requested review from loichenninger

@RemiVerriez RemiVerriez Awaiting requested review from RemiVerriez

1 more reviewer

@nsenave nsenave nsenave left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexisszmundy @nsenave