Skip to content

Nouveau modèle de données Genesis #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexisszmundy merged 27 commits into from
Feb 14, 2025
Merged

Nouveau modèle de données Genesis #163

alexisszmundy merged 27 commits into from
Feb 14, 2025

Conversation

@alexisszmundy
Copy link
Contributor

@alexisszmundy alexisszmundy commented Feb 7, 2025

Cette PR est la fusion de #162 et #149
Avec :

  • Changement de nom des id pour être type Id (ex: idCampaign -> campaignId)
  • Séparation de idLoop en scope et iteration (idLoop : "BOUCLE_PRENOMS_1" -> scope: "BOUCLE_PRENOMS" et iteration: 1)
  • Refactos de noms de variables et méthode pour correspondre avec leur type

loichenninger and others added 21 commits January 8, 2025 15:10
@loichenninger
Rename idUE, idQuest and IdCampaign
96e09c7
@loichenninger
Standardisation of ids name with the rule <prefix>Id
ce14419
@loichenninger
End of refactor on ids name
cff5812
@loichenninger
Remaining IdLoop
d1a5284
@loichenninger
Remaining IdUE
2ff95aa
@loichenninger
Removing idLoop from endpoints used by data quality application
b54e97d
@alexisszmundy
refactor: Changed more ids
2604bdc 
IdUE -> interrogationId
idCampaign -> campaignId
idQuestionnaire -> questionnaireId
@alexisszmundy
refactor: use correct name for models/dtos
6c29440 
Notably in lambdas functions
@loichenninger
fix: resolve conflicts
8706dd1
@loichenninger
fix: correction of invalid step name
f10b197
@alexisszmundy
Merge branch 'main' into devIteration
13b7a78
@alexisszmundy
fix: fixes after conflicts
ee33f96
@alexisszmundy
feat!: Iteration and value instead of iteration in loopId and values …
0d9ab80 
…array
@alexisszmundy
feat!: renamed loopId to scope
241c46b
@alexisszmundy
fix(cucumber): changed to scope
8b9fcff
@alexisszmundy
fix: null iteration in latest states get
eb2b585
@alexisszmundy
feat: edited variables service use metadatas to get scope
1f78774
@alexisszmundy
Merge branch 'devRenameIds' into devNewModel
b079a54
@alexisszmundy
Merge branch 'devIteration' into devNewModel
0d1ad48
@alexisszmundy
fix: fixes after merge
1375f81
@alexisszmundy
refactor: use correct names
fac2a22
This was referenced Feb 7, 2025
Closed
Closed
alexisszmundy and others added 4 commits February 10, 2025 16:18
@alexisszmundy
test: Add KO tests for missing variables in get latest states
d4f1587
@alexisszmundy
fix: fixes after first tests on DV (get latest states)
d017dee 
- renamed surveyUnitId on interrogationId in DTO
- fixed only get first iterations on collected variables
- fixed iteration 0 on external variables
@alexisszmundy
fix:(test) fixed unit tests to get first iteration
51cb1f1
@loichenninger
fix: bug where we lost data
94a4bf1
@alexisszmundy alexisszmundy merged commit 0130794 into main Feb 14, 2025
3 checks passed
@loichenninger loichenninger deleted the devNewModel branch March 24, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loichenninger loichenninger loichenninger approved these changes

@alicela alicela Awaiting requested review from alicela

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexisszmundy @loichenninger