-
Notifications
You must be signed in to change notification settings - Fork 4
Get review indicator (for NOQUAL Perret) #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
71c42ed
feat: get review indicator
alexisszmundy dc31737
fix: back office access
alexisszmundy 27d8395
chore: remove unused
alexisszmundy cb56067
Merge branch 'main' into devGetReview
alexisszmundy faa5c99
Merge branch 'main' into devGetReview
alexisszmundy a677a01
fix: authorize user platine to get review indicator
alexisszmundy 69734d5
Merge branch 'main' into devGetReview
loichenninger 094d966
docs: javadoc
alexisszmundy 5efdddc
doc: update changelog
alexisszmundy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| # Changelog | ||
| ## 1.12.0 [TODO] | ||
| - Get review indicator endpoint | ||
|
|
||
| ## 1.11.0 [2025-10-20] | ||
| ### Added | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,11 +46,11 @@ public class DataProcessingContextController { | |
|
|
||
| @Operation(summary = "Create or update a data processing context") | ||
| @PutMapping(path = "/review") | ||
| @PreAuthorize("hasAnyRole('USER_BACK_OFFICE','SCHEDULER')") | ||
| @PreAuthorize("hasAnyRole('USER_PLATINE', 'USER_BACK_OFFICE', 'SCHEDULER')") | ||
| public ResponseEntity<Object> saveContext( | ||
| @Parameter(description = "Identifier of the partition", required = true) @RequestParam("partitionId") String partitionId, | ||
| @Parameter(description = "Allow reviewing") @RequestParam(value = "withReview", defaultValue = "false") Boolean withReview | ||
| ) { | ||
| ){ | ||
| try { | ||
| withReview = withReview != null && withReview; //False if null | ||
| dataProcessingContextApiPort.saveContext(partitionId, withReview); | ||
|
|
@@ -60,6 +60,20 @@ public ResponseEntity<Object> saveContext( | |
| return ResponseEntity.ok().build(); | ||
| } | ||
|
|
||
| @Operation(summary = "Returns partition review indicator") | ||
| @GetMapping(path = "/review") | ||
| @PreAuthorize("hasAnyRole('USER_BACK_OFFICE','SCHEDULER','USER_PLATINE')") | ||
| public ResponseEntity<Object> getReviewIndicator( | ||
| @Parameter(description = "Identifier of the partition", required = true) @RequestParam("partitionId") String partitionId | ||
| ){ | ||
| try { | ||
| boolean withReview = dataProcessingContextApiPort.getReviewByPartitionId(partitionId); | ||
| return ResponseEntity.ok(withReview); | ||
| }catch (GenesisException e){ | ||
| return new ResponseEntity<>(e.getMessage(), HttpStatusCode.valueOf(e.getStatus())); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. plutôt à faire via les |
||
| } | ||
| } | ||
|
|
||
| @Operation(summary = "Schedule a Kraftwerk execution") | ||
| @PutMapping(path = "/schedules") | ||
| @PreAuthorize("hasRole('USER_KRAFTWERK')") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.