Update CsvOutputFiles.java #314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexisszmundy
approved these changes
Jul 29, 2025
| } | ||
| //Merge header and data | ||
| try (var output = Files.newOutputStream(tmpOutputFile, StandardOpenOption.APPEND); | ||
| var input = Files.newInputStream(Path.of(tmpOutputFile.toAbsolutePath() + "data"))) { |
Contributor
There was a problem hiding this comment.
Prefer using Path.resolve() for path construction over string concatenation
| Map<String,String> columns = SqlUtils.getColumnTypes(getDatabase(), datasetName); | ||
|
|
||
| if(columnNames.isEmpty()){ | ||
| if(columns.isEmpty()){ |
Contributor
There was a problem hiding this comment.
Is it really a return we want if columns is empty? Maybe a continue is better to not interrupt the writing process for next datasets.
| input.transferTo(output); | ||
| } | ||
| Files.deleteIfExists(Path.of(tmpOutputFile + "data")); | ||
| String content = Files.readString(tmpOutputFile); |
Contributor
There was a problem hiding this comment.
I am afraid that we could have performance issues here. If i am not mistaken Files.readString() will put all the content of the file in RAM, which can be a problem for big files.
Suggestion : deport this logic in a method where we use stream to read line by line the file, something like :
Path tempFile = Files.createTempFile("csv_clean_", ".tmp");
try (BufferedReader reader = Files.newBufferedReader(file);
BufferedWriter writer = Files.newBufferedWriter(tempFile, StandardOpenOption.WRITE)) {
String line;
while ((line = reader.readLine()) != null) {
writer.write(line.replace(NULL_MARKER, "\"\""));
writer.newLine();
}
}
Files.move(tempFile, file, java.nio.file.StandardCopyOption.REPLACE_EXISTING);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.