Skip to content

feat: resetable external variables #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laurentC35 merged 2 commits into from
Dec 15, 2025
Merged

feat: resetable external variables #399

laurentC35 merged 2 commits into from
Dec 15, 2025

Conversation

@nsenave
Copy link
Contributor

@nsenave nsenave commented Nov 28, 2025

Update Pogues-Model so that the isDeletedOnReset property gets serialized/deserialized.

@nsenave nsenave self-assigned this Nov 28, 2025
@nsenave nsenave added the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 28, 2025
@github-actions github-actions bot removed the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Nov 28, 2025
@github-actions
Copy link

github-actions bot commented Nov 28, 2025

👋 Version 4.25.0-SNAPSHOT deployed on docker hub

chloe-renaud
chloe-renaud requested changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@chloe-renaud chloe-renaud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VariableDTO and the Variable CRUD service should also be updated to handle setting the property on put, and return the property on fetch

@nsenave nsenave requested a review from chloe-renaud December 1, 2025 12:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nsenave nsenave added the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Dec 1, 2025
@github-actions github-actions bot removed the deploy-snapshot To be used in PR to trigger snapshot deploy pipeline label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

👋 Version 4.25.0-SNAPSHOT.1 deployed on docker hub

@laurentC35 laurentC35 merged commit ba4b7d1 into rc/4-25-0 Dec 15, 2025
11 checks passed
@laurentC35 laurentC35 deleted the feat/resetable-external-vars branch December 15, 2025 09:58
@laurentC35 laurentC35 mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurentC35 laurentC35 laurentC35 approved these changes

@RemiVerriez RemiVerriez RemiVerriez approved these changes

@chloe-renaud chloe-renaud chloe-renaud approved these changes

Assignees

@nsenave nsenave

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nsenave @laurentC35 @RemiVerriez @chloe-renaud