Skip to content

Feat/formatter (Resolves #415)#418

Merged
NicoLaval merged 7 commits intodevelopfrom
feat/formatter
May 27, 2025
Merged

Feat/formatter (Resolves #415)#418
NicoLaval merged 7 commits intodevelopfrom
feat/formatter

Conversation

@NicoLaval
Copy link
Collaborator

No description provided.

@NicoLaval NicoLaval changed the title Feat/formatter Feat/formatter (Resolves #415) May 26, 2025
@NicoLaval
Copy link
Collaborator Author

NicoLaval commented May 26, 2025

Hi @noahboerger @hadrienk @romaintailhurat,

PR links to #415 issue.

Please, to review this PR:

  • check the parent pom update
  • check the GHA CI file update
  • check the CONTRIBUTING.md update
  • checkout feat/formatter branch to check that the code style suits you

Copy link
Collaborator

@noahboerger noahboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @NicoLaval, for integrating Google Code Formatting into the Maven settings and CI workflow. I like how it has been implemented.

@NicoLaval NicoLaval merged commit 155732b into develop May 27, 2025
6 of 8 checks passed
@NicoLaval NicoLaval deleted the feat/formatter branch May 27, 2025 18:29
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
53.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants