Issue 5818 resolve merge conflicts from PR 5837 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#614176](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/614176) --------- Co-authored-by: Dishant Chourasia <[email protected]>
…assword (#5814) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Handle scenario when OpenPasswordChangeDialog is called, but OldPassword is not entered, so we expect an error about password mismatch. Add test for that scenario as well. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #5587 Fixes [AB#616472](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616472)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This commit updates ReplaceInvalidFilterChar() in codeunit 8021 Text Management to also sanitize the = character, preventing invalid SETFILTER errors when Subscription Package Code contains = (e.g., INVALID=) during subscription creation. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #5813 Fixes [AB#616471](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616471)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This PR adds support for multi-language testing, copilot capability tracking, and test run frequency classification. These additions enable better organization and automation of AI tests across different languages and execution scenarios. 1. Multi-Language Support - Added support for language for test inputs in the Data-Driven test extension. Localized versions of datasets are linked to one parent dataset. - Added support in the AI Test Tool for suites to have one or more languages, based on the localized versions of datasets. - When running tests, the toolkit automatically selects the language-specific dataset based on the suite's language setting. If no language is set and a parent dataset is used, it defaults to en-US. 2. Copilot Capability Tracking - Added Copilot Capability field to AIT Test Suite table. - Enables categorization of test suites by the Copilot capability they test. 3. Run Frequency Classification - Added Run Frequency enum with values: Manual, Daily, Weekly. - Can be set at both _suite level_ and _per-language_ level, to use in automation 4. Test Type and Validation - Added Test Type enum with values: Copilot, Agent, MCP. - Added Validation boolean flag at suite and language level for validation test identification, to use in automation 5. Updated Test Suite Import/Export - Updated the XML import/export functionality to support all new fields. - Validation attribute is only exported when true to keep XML clean. Example test suite: ``` <AITSuite Code="W1-SOA" Description="Sales Order Agent Tests" Capability="Sales Order Agent" TestType="Agent" Frequency="Daily" Validation="True" TestRunnerId="130451"> <Language Tag="cs-CZ" Frequency="Weekly" /> <Language Tag="da-DK" Frequency="Weekly" /> <Line CodeunitID="133500" Description="Example" Dataset="MULTILANG-DATASET" /> </AITSuite> ``` #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#578022](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/578022) Fixes [AB#615697](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615697)
… triggers #611287 (#5822) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Calling Modify in the middle of validation code is not very good. We need to refactor this part of the code. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#611287](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/611287/?view=edit)
Make minor refactoring and add more countries [AB#611502](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/611502/)
This PR contains the following changes: - Update BCArtifact version. New value: 28.0.43563.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <[email protected]>
…(+ 1 more update(s)) (#5856) This PR contains the following changes: - Update app baselines package version. New value: 27.3.43562.0 - Update translation package version. New value: 28.0.25349.4 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: aholstrup1 <[email protected]>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Add support for Policy configuration via AOAI Policy Params. Support for enabling/disabling XPIA detection. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#561651](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/561651) Some regressions noted in PA-Harms test for UPIA datasets (4 datasets). I have manually reviewed 5 failing cases from each of the failing dataset and it looks to be False positive. So we should be good to go with this. --------- Co-authored-by: Dishant Chourasia <[email protected]> Co-authored-by: Darrick <[email protected]>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Fix build break in with AL0897 Started failing after c704b15 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Related to [AB#615697](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615697)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#614176](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/614176) Co-authored-by: Dishant Chourasia <[email protected]>
This PR contains the following changes: - Update BCArtifact version. New value: 28.0.43599.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <[email protected]>
#### Summary <!-- Provide a general summary of your changes --> The parameters in the method: `procedure RequestDislikeFeedback(....,..., ContextProperties, ContextFiles)` were in the wrong order. Moved ContextFiles to before ContextProperties #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#615526](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615526) --------- Co-authored-by: Eddy Lynch <[email protected]>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Minor UX improvements to the early access preview experience. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#616526](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616526)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Exclude AIT Test Suite Language table from cloud migration #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#616551](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/616551/)
Rename: - Quality Inspection Test -> Quality Inspection - Qlty. In. Test Generation Rule -> Qlty. Inspection Gen. Rule - Retest -> Re-inspection - Quality Grade -> Quality Inspection Result - Quality Field -> Quality Test - Remove Microsoft.QualityManagement.Setup.Setup namespace. Introduce Microsoft.QualityManagement.Installation namespace Fixes [AB#615822](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615822)
This PR contains the following changes: - Update BCArtifact version. New value: 28.0.43663.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <[email protected]>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary When user clicks Provide Feedback, lets make it easy for them to include the data source #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#616500](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616500) Co-authored-by: Magnus Hartvig Grønbech <[email protected]>
New first party app for using PEPPOL to export sales and service documents. This only adds the app, next steps would be integration with existing steps in Base-app. # Architecture Design Pattern: Strategy via Enum + Interfaces The core design uses an extensible enum (PEPPOL 3.0 Format) that implements 11 specialized interfaces. This allows: Polymorphic behavior based on document type (Sales vs Service) Clean separation of concerns across different functional areas Extensibility for future document types or formats ┌─────────────────────────────────────────────────────────────────────┐ │ PEPPOL 3.0 Format (Enum) │ │ ┌─────────────────────┐ ┌─────────────────────────────────┐ │ │ │ PEPPOL 3.0 - Sales │ │ PEPPOL 3.0 - Service │ │ │ └─────────────────────┘ └─────────────────────────────────┘ │ │ │ │ │ │ ▼ ▼ │ │ ┌─────────────────────┐ ┌─────────────────────────────────┐ │ │ │ Sales Validation │ │ Service Validation │ │ │ │ Sales Export Mgmt │ │ Services Export Mgmt │ │ │ └─────────────────────┘ └─────────────────────────────────┘ │ │ │ │ Default Implementation (shared): PEPPOL30 Management │ │ - Attachment Handler, Delivery Info, Document Info, Line Info │ │ - Monetary Info, Party Info, Payment Info, Tax Info │ │ - Posted Document Iterator │ └─────────────────────────────────────────────────────────────────────┘<html> ## Interfaces <img width="909" height="507" alt="image" src="https://github.com/user-attachments/assets/15d1c825-a5a1-4e25-89a1-431007c7d9c1" /> ## Folder Structure App/ ├── app.json # App manifest (ID range: 37200-37300) └── src/ ├── Management/ # Core shared logic │ ├── Codeunits/ │ │ ├── PEPPOL30Management.Codeunit.al # Public facade (implements 9 interfaces) │ │ ├── PEPPOL30ManagementImpl.Codeunit.al # Internal implementation │ │ ├── PEPPOL30SalesValidation.Codeunit.al # Sales validation (implements PEPPOL30 Validation) │ │ ├── PEPPOL30ServiceValidation.Codeunit.al # Service validation (implements PEPPOL30 Validation) │ │ ├── PEPPOL30ValidationImpl.Codeunit.al # Shared validation logic (Internal) │ │ ├── PEPPOL30Initialize.Codeunit.al # Electronic Document Format registration │ │ └── PEPPOL30Install.Codeunit.al # Install codeunit │ ├── Enums/ │ │ └── PEPPOL30Format.Enum.al # Central polymorphic enum │ └── Interfaces/ # 11 interface definitions │ ├── Sales/ # Sales-specific functionality │ ├── Codeunits/ │ │ ├── ExpSalesInvPEPPOL30.Codeunit.al # Sales Invoice export entry point │ │ ├── ExpSalesCrMPEPPOL30.Codeunit.al # Sales Credit Memo export entry point │ │ └── PEPPOL30SalesExportMgmt.Codeunit.al # Sales export management (implements PEPPOL30 Export Management) │ └── XmlPorts/ │ ├── SalesInvoicePEPPOL30.XmlPort.al # Invoice UBL XML generation │ └── SalesCrMemoPEPPOL30.XmlPort.al # Credit Memo UBL XML generation │ ├── Services/ # Service-specific functionality │ └── Codeunits/ │ ├── ExpServInvPEPPOL30.Codeunit.al # Service Invoice export entry point │ ├── ExpServCrMPEPPOL30.Codeunit.al # Service Credit Memo export entry point │ └── PEPPOL30ServicesExportMgmt.Codeunit.al # Service export management (implements PEPPOL30 Export Management) │ └── Setup/ # Configuration ├── CompanyInformation.TableExt.al # Adds PEPPOL format selection fields └── CompanyInformation.PageExt.al # UI for format selection Test/ ├── app.json └── src/ └── PEPPOL30ManagementTests.Codeunit.al # Comprehensive test coverage ## Key Components 1. Format Selection (Company Information) Two new fields allow configuration of PEPPOL format per document type: - PEPPOL 3.0 Sales Format - Format for Sales Invoices and Credit Memos - PEPPOL 3.0 Service Format - Format for Service Invoices and Credit Memos **This could be changed to its own setup page.** ## How export works Export Codeunit (e.g., Exp. Sales Inv. PEPPOL30) │ ├── 1. Get PEPPOL30 Validation interface from CompanyInfo format │ └── Call ValidateInvoice() / ValidateCreditMemo() │ ├── 2. Call GenerateXMLFile() │ └── Initialize XMLPort with format enum │ └── 3. XMLPort uses interfaces for all data: ├── Document Info Provider → GetGeneralInfoBIS() ├── Party Info Provider → GetAccountingSupplierPartyInfo() ├── Tax Info Provider → GetTaxTotalInfo() ├── Export Management → FindNextRec(), FindNextLineRec() └── ... (other providers) This Pull request related with microsoft/BusinessCentralApps#1595 Fixes [AB#563709](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/563709) --------- Co-authored-by: Andrius Andrulevičius <[email protected]> Co-authored-by: Andrius Andrulevičius <[email protected]> Co-authored-by: Grasiele Matuleviciute <[email protected]> Co-authored-by: Grasiele Matuleviciute <[email protected]> Co-authored-by: Magnus Hartvig Grønbech <[email protected]>
…-v28 Subscription Billing App v28 changes. <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> ### Summary #### General Notes: - Revamped report pages, updated visuals and added new visuals - Enhanced support for dimension tables through dynamic visuals - Implemented Backlinks for Customer/Vendor Contract Lines and Deferral Lines, across table and matrix visuals. - Added Item Category Hierarchy support - Added Conditional Formatting across Table and Matrix visuals for Back Link integration and to enhance key measures #### Fixes/Tweaks: - Updated financial measure formatting to be consistent with other report apps - Updated theme to be consistent with other report apps - Replaced all Fiscal Measures on visuals with Fiscal Year Hierarchy for Drill Down Support - Replaced all Item Category fields on visuals with new Item Category Hierarchy for Drill Down Support - Updated visibility for measures utilised on report pages. #### Report Page Updates ##### Subscription Overview * Added KPI Cards visuals for key measures * Updated Top 5 Customer and Top 5 Vendor visuals to Stacked Bar Charts * Added Total Contract Value by Package Pie Chart * Removed Change in Mon Recurring Revenue by Year Month * Removed Mon Recurring Revenue by Calendar Year Month ##### Revenue Year-Over-Year * Added Mon. Recurring Revenue by Package Bar Chart * Added Conditional Formatting to Mon. Recurring Revenue Matrix visual ##### Revenue Analysis * Added Mon. Recurring Revenue by Item Category Bar Chart visual * Added Mon. Recurring Revenue by Salesperson Bar Chart visual ##### Revenue Development * Updated Styling and Fiscal Date handling ##### Churn Analysis * Added Avg. Mon Churn Rate % by Year and Month * Added Chur/Downgrade by CustomerBar Chart ##### Revenue by Item * Added Profitability by Item Category Scatter Chart, to visualize Profit, Revenue and Active Customer metrics. * Added Item Category Hierarchy and Active Customer field to visuals * Changed Mon. Recurring Revenue by Item Column Chart to Tree Map ##### Revenue by Customer * Added Mon. Recurring Revenue by Customer Location Map visual * Added Active Customer field to matrix visual ##### Revenue by Salesperson * Added Profitability by Salesperson Scatter Chart, to visualize Profit, Revenue and Active Customer metrics. * Added Active Customer field to matrix visual ##### Total Contract Value Year-Over-Year * Added conditional formatting to matrix visual ##### Total Contract Value Analysis * Added Total Contract Value by Package Bar Chart visual * Added Total Contract Value by Salesperson Bar Chart visual ##### Customer Deferrals * Added Customer Deferrals by Released Status Pie Chart ##### Vendor Deferrals * Added Vendor Deferrals by Released Status Pie Chart ##### Sales and Cost Forecast * Renamed Report page from 'Sales and Cost Forecast Forecast' to 'Sales and Cost Forecast' to be consistent with embedded report naming * Added conditional formatting to matrix visual ##### Billing Forecast * Added conditional formatting to matrix visual #### Work Item(s) Subscription Billing App v28 updates [AB#615437](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615437) --------- Co-authored-by: Tuan Nguyen <[email protected]> Co-authored-by: Johnathan Gonzalez <[email protected]>
…ted when creating negative adjustment from quality test (#5825) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Posting is not possible in Item Journal for negative adjustment entries, if batch has No. Series defined with allowed Manual Nos. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#610785](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/610785)
…he Qlty. Inspection Test Lines (20413, List) (#5876) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#615722](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/615722/?view=edit)
#### Summary I have added a module for handling SFTP connections directly from Business Central.  This requires a SFTP service. A raspberry pi on the local network is sufficent for testing, but [Azure Blob Storage can also provides a testing scenario](https://learn.microsoft.com/en-us/azure/storage/blobs/secure-file-transfer-protocol-support). #### Work Item(s) Fixes #3686 #### DLL install process 1. Download these two nuget packages: https://www.nuget.org/packages/ssh.net/ https://www.nuget.org/packages/BouncyCastle.Cryptography/ 2. Extract the DLL's: `lib\net8.0\Renci.SshNet.dll` `lib\net6.0\BouncyCastle.Cryptography.dll` 3. Place in service tier's `Add-Ins`-folder and in one of the `al.assemblyProbingPaths`. My internal checklist for this PR: - [x] Get approval of SSH.NET + BouncyCastle.Cryptography for Business Central - [x] Get a different number range (Not 50000..100000) - [x] Update `app.json` to reflect the module - [x] Namespaces for all files - [x] Handle different types of exceptions (Connection errors, etc) - [x] ~~Remove SFTP Client debugging page~~ - [x] Expand the "SFTP Operation Response" to contain Errors (Like ABS Operation Response) - [x] Consider a stateless API - [x] Add tests - [x] Handle upload/download better if possible - Currently I'm downloading all the bytes and passing it to a MemoryStream, but I would like to simply get a stream. However I cannot seem to invoke the functions (The last parameter `Action<ulong>? downloadCallback = null` is tricky to make in Business Central dotnet integration). - Upload could use [UploadFile(Stream, string, Action<ulong>?)](https://sshnet.github.io/SSH.NET/api/Renci.SshNet.SftpClient.html#Renci_SshNet_SftpClient_UploadFile_System_IO_Stream_System_String_System_Action_System_UInt64__) - Download could use [DownloadFile(string, Stream, Action<ulong>?)](https://sshnet.github.io/SSH.NET/api/Renci.SshNet.SftpClient.html#Renci_SshNet_SftpClient_DownloadFile_System_String_System_IO_Stream_System_Action_System_UInt64__) Fixes [AB#351397](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/351397) --------- Co-authored-by: Jesper Schulz-Wedde <[email protected]>
…view - 0f87755 / Related to AB#539394 (#5882) ## preview Note that when using the preview version of AL-Go for GitHub, we recommend you Update your AL-Go system files, as soon as possible when informed that an update is available. ### Issues - Issue 2004 PublishToAppSource workflow publishes multi-app repos in alphabetical order instead of dependency order - Issue 2045 DateTime parsing fails on non-US locale runners in WorkflowPostProcess.ps1 - Issue 2055 When using versioningStrategy 3+16, you get an error when building - AL-Go repositories with large amounts of projects may run into issues with too large environment variables - Discussion 1855 Add trigger 'workflow_call' to workflow 'Update AL-Go System Files' for reusability ### Set default values for workflow inputs The `workflowDefaultInputs` setting now also applies to `workflow_call` inputs when an input with the same name exists for `workflow_dispatch`. This ensures consistent default values across both manual workflow runs and reusable workflow calls. Read more at [workflowDefaultInputs](https://aka.ms/algosettings#workflowDefaultInputs). ### AL-Go Telemetry updates AL-Go telemetry now includes test results so you can more easily see how many AL tests, Page Scripting tests and BCPT tests ran in your workflows across all your repositories. Documentation for this can be found on [this article](https://github.com/microsoft/AL-Go/blob/main/Scenarios/EnablingTelemetry.md) on enabling telemetry. Related to [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <[email protected]>
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary Fixes regression in the prompt. Seems that these instruction produces better results in being more eager to match. - [x] Waiting for Accuracy and Harms testing to complete. https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_git/NAV/pullrequest/235205 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#615905](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615905) --------- Co-authored-by: Magnus Hartvig Grønbech <[email protected]>
…d it be searchable via TellMe? (#5875) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#615705](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/615705/?view=edit)
… searchabe via TellMe (#5874) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#615707](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/615707/?view=edit)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Remved links from InstructionalText as it is not showned as a link. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#610859](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/610859/?view=edit)
…ews (#5871) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#610856](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/610856/?view=edit)
…em with no tracking (#5840) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> For Purchase Order with two lines, one Item is tracked by Lot No., and second Item has no tracking details, both tests are created with the same Lot No. from Item Tracking Line for first Item #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#615757](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/615767)
This PR contains the following changes: - Update BCArtifact version. New value: 28.0.43700.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <[email protected]>
…2: Build ID 2354279 (#5887) This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc. [AB#615437](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615437)
This PR contains the following changes: - Update BCArtifact version. New value: 28.0.43739.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <[email protected]>
…nt that is current works on embedded resources (#5743) ### The goal of demo experience for payables agent The goal of demo experience for payables agent is to have both inbound e-documents as part of the evaluation companies <img width="3192" height="713" alt="image" src="https://github.com/user-attachments/assets/585b2c8a-522e-48f8-b282-c7faf2f6197f" /> and also sample invoices will be used when user configures the payables agent. <img width="1263" height="558" alt="image" src="https://github.com/user-attachments/assets/8757c5ae-59f5-4cd6-9d9c-10b0f02603b5" /> So, user can run the full scenario of taking the PDF, processing it by payables agent and having the purchase invoice to post and linked to the draft document. ### Current implementation The current implementation use the approach of generating the ADI jsons and PDFs separately and storing them in the ".resources" folder which bring the following implementation: 1. This approach will not work with translations 2. Going to fail in the next year because the date is hardcoded in the json 3. Made it extremely hard to support the Contoso Demotool because it is required to find the hardcoded value in the json to change it ### New implementation Contains of three parts: 1. A new way of generating inbound e-documents. 2. Sample purchase invoice functionality. 3. Test codeunit that proves that sample invoices are correctly handled on top of newly generated inbound e-documents. _**New way of generating inbound e-documents**_ The new approach is to mock all the required e-document entities. Now it is going to work for translations, new dates and much easier to make changes in Contoso Demotool. A codeunit for reference: **"Contoso Inbound E-Document"**. The goal of the codeunit is to create purchase invoices, post them and then mock all the necessary e-document entities to behave like inbound e-documents. _**Sample purchase invoice functionality**_ The goal of the functionality is to generate PDF and use if for demo invoices as part of the evaluation company and also for sample invoices that is used for payables agent. The core logic is in the **"E-Doc Sample Purchase Invoice"** codeunit that takes custom purchase header and line tables (these are new tables with limited set of fields). The Generate method calls the new report, save the result as PDF and save it in the new **"E-Doc Sample Purch. Inv File"** table. The record from this table will be used by the Payables Agent when user run the sample invoice guide in the evaluation company. Sample invoice functionality is also used by the "E-Document Demodata" app in the **"Contoso Inbound E-Document"** codeunit. The reason why the sample invoice functionality is part of the E-Document Core and not E-Document Demodata is that we have a further plans on utilizing this functionality for regular tests of payables agent. _**Test codeunit**_ Dataset contains a list of sample invoices per country and expected results after processing. When the test runs, it takes all the sample invoices from the **"E-Doc Sample Purch. Inv File"** table per country, processes them through the ADI, verifies the information in the draft document, finalizees and then posts the purchase invoice. _ADO PR where this functionality is used:_ https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_git/NAV/pullrequest/234414 [AB#579972](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/579972/)
…is. where is it coming from and how it is used? (#5897) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Renamed field "Result Priority" to "Evaluation Sequence", because it's copied from "Evaluation Sequence" from Result. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#615772](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/615772/?view=edit)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Additional validation on task creation: 1. Check that a message is included to ensure a user intervention is raised before the task runs 2. Check that the agent has at least some permissions in the company where the task is created #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#616256](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616256) Fixes [AB#616649](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616649)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary Changes needed to be able to uptake the part on the Sales Order agent and custom agent #### Work Item(s) Fixes [AB#597811](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/597811)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#614176](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/614176) Co-authored-by: Dishant Chourasia <[email protected]>
…fferently then other views (#5898) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Align sorting on views #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#616923](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/616923/?view=edit)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Updated application area related exclusively to Manufacturing #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#610428](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/610428/?view=edit)
#### Work Item(s) Fixes [AB#616938](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616938) Co-authored-by: Joshua Martínez Pineda <[email protected]>
…zard (#5902) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Show/Hide group depending whether Essential/Premium experience is enabled. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#616922](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/616922/?view=edit)
…h 'AboutTitle' as 'About This Field' that does not give a good user experience (#5901) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Removed AboutTitle property from page fields, as it's not aligned with base app usage for the same property. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#615304](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/615304/?view=edit)
This PR contains the following changes: - Update BCArtifact version. New value: 28.0.43826.0 [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Co-authored-by: mazhelez <[email protected]>
…soft.com/... and aka.ms in the labels (#5925) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Removed aka.ms and microsoft learn links from labels #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#610920](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/610920/?view=edit)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary Not needed anymore. We kept it for old repo due to links. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes # [AB#614186](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/614186)
…es (#5967) Navigate to Results list from Result Code Add missing Drill Down for Inspection Lines Fixes: - [AB#615771](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615771) - [AB#617015](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617015)
…ties. Extra changes. (#5991) This PR contains minor changes required to adding new demo data for PA: - Fixing preparation of the temporary buffer before doing historical matching, specifically for allocation account. The reason is that the name of the allocation account is different from what we have in the purchase invoice lines after splitting the allocation account to G/L accounts. - Fixing sample purchase invoice functionality by populating the description on the lines - Adding new countries to demodata app.json [AB#579972](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/579972/)
…5932) Improving inbound e-document page: - Show task id for the inbound e-document and open the task pane when user click the field - Show both confirmed and extracted vendors - Change first fields on the inbound e-documents page based on the UX review Side: Add missing sorting for using statements to pass the build Fixes [AB#607925](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/607925)
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#614168](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/614168)
Reverting unnecessary change to the inbound e-documents page that make the Import PDF action visible Fixes [AB#579972](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/579972)
…y Order Lines (#5964) ### Summary Enhanced the Shopify Order Subform page to automatically set the Unit of Measure Code when an Item is selected on an order line. ### Changes **File:** ShpfyOrderSubform.Page.al - Added `OnValidate` trigger to the "Item No." field that automatically populates the "Unit of Measure Code" based on the selected item: - If the item has a "Sales Unit of Measure" defined, it uses that value - Otherwise, it falls back to the item's "Base Unit of Measure" ### Motivation When users manually map Shopify order lines to Business Central items, they previously had to manually enter the Unit of Measure Code. This change improves the user experience by automatically defaulting the UoM based on the item's configuration, reducing manual data entry and potential errors. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#617019](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617019)
## Add Data Capture support for Fulfillment Orders ### Summary This PR adds Data Capture functionality for Fulfillment Orders, mirroring the existing implementation for Order Fulfillments. This allows users to view the raw JSON data retrieved from Shopify for debugging and troubleshooting purposes. ### Changes #### Pages - **ShpfyFulfillmentOrderCard.Page.al**: Added "Retrieved Shopify Data" action with `actionref` in the promoted area to view captured data for the selected fulfillment order - **ShpfyFulFillmentOrders.Page.al**: Added the same "Retrieved Shopify Data" action to the list page for quick access from the list view #### Table - **ShpfyFulFillmentOrderHeader.Table.al**: Extended `OnDelete` trigger to clean up associated Data Capture records when a fulfillment order header is deleted #### Codeunit - **ShpfyFulfillmentOrdersAPI.Codeunit.al**: - Added `DataCapture.Add()` call in `ExtractFulfillmentOrder` to save the fulfillment order JSON response - Added `DataCapture.Add()` call in `ExtractFulfillmentOrderLines` to save the fulfillment order lines JSON response #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#616999](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616999)
### Summary This PR adds extensibility for Shopify product metafields, allowing external developers to programmatically manage metafields through a public facade codeunit and integration events. ### Problem External developers cannot programmatically: - Retrieve metafield definitions for products/variants - Add metafields with values when missing - Force-sync metafields to Shopify outside of the standard item sync ### Solution Implemented a public facade pattern (similar to existing `Shpfy Product` and `Shpfy Orders` codeunits) for metafield management. ### Changes - **ShpfyMetafields.Codeunit.al** - Public facade codeunit with: - `GetMetafieldDefinitions(ParentTableNo, OwnerId, ShopCode)` - Retrieve metafield definitions from Shopify - `SyncMetafieldToShopify(Metafield, ShopCode): BigInteger` - Sync a single metafield to Shopify - `SyncMetafieldsToShopify(ParentTableNo, OwnerId, ShopCode)` - Sync all metafields for a resource - **ShpfyProductEvents.Codeunit.al** - Added `OnBeforeUpdateProductMetafields(ProductId: BigInteger)` integration event - **ShpfyProductExport.Codeunit.al** - Raises `OnBeforeUpdateProductMetafields` event before syncing metafields - Refactored to use public facade for metafield operations - **ShpfyMetafields.Page.al** - Added "Sync to Shopify" action with multi-select support - Refactored to use public facade for all metafield operations - **ShpfyCustomerExport.Codeunit.al** - Refactored to use public facade for metafield sync - **ShpfyCompanyExport.Codeunit.al** - Refactored to use public facade for metafield sync #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#617035](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/617035)
…rkflows in the external-dependencies group across 1 directory (#5891) Bumps the external-dependencies group with 1 update in the /.github/workflows directory: [step-security/harden-runner](https://github.com/step-security/harden-runner). Updates `step-security/harden-runner` from 2.13.3 to 2.14.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/step-security/harden-runner/releases">step-security/harden-runner's releases</a>.</em></p> <blockquote> <h2>v2.14.0</h2> <h2>What's Changed</h2> <ul> <li>Selective installation: Harden-Runner now skips installation on GitHub-hosted runners when the repository has a custom property skip_harden_runner, allowing organizations to opt out specific repos.</li> <li>Avoid double install: The action no longer installs Harden-Runner if it’s already present on a GitHub-hosted runner, which could happen when a composite action also installs it.</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/step-security/harden-runner/compare/v2.13.3...v2.14.0">https://github.com/step-security/harden-runner/compare/v2.13.3...v2.14.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/step-security/harden-runner/commit/20cf305ff2072d973412fa9b1e3a4f227bda3c76"><code>20cf305</code></a> Merge pull request <a href="https://redirect.github.com/step-security/harden-runner/issues/622">#622</a> from step-security/feature/custom-property-skip</li> <li><a href="https://github.com/step-security/harden-runner/commit/c51e8eeb6c4fdcd08f65e43a051dacdbfaa69702"><code>c51e8ee</code></a> feat: skip agent install and post step on subsequent runs for GitHub-hosted r...</li> <li><a href="https://github.com/step-security/harden-runner/commit/e152b90204c3d85cefa1441b701a47a13ed28bd7"><code>e152b90</code></a> feat: skip harden-runner based on repository custom property</li> <li><a href="https://github.com/step-security/harden-runner/commit/ee1faec052d1000061fa79a13e030db11b3f86bd"><code>ee1faec</code></a> feat: replace skip-harden-runner with skip-on-custom-property input</li> <li><a href="https://github.com/step-security/harden-runner/commit/1dc7c1764659d537dab2a854b8e165a801103eb1"><code>1dc7c17</code></a> feat: add skip-harden-runner input to conditionally skip execution</li> <li>See full diff in <a href="https://github.com/step-security/harden-runner/compare/df199fb7be9f65074067a9eb93f12bb4c5547cf2...20cf305ff2072d973412fa9b1e3a4f227bda3c76">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> [AB#539394](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/539394) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#6012) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#615833](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/615833)
…ry for ".." entry (#5894) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Issue: When using the folder selection dialog, if a user navigates into a directory and then selects the ".." (back/parent) entry and clicks OK, the function returns an invalid path containing the literal ".." segment (e.g., Docs/mine/2025/../). Fix: Added a check to detect when the ".." navigation entry is selected and return the current directory path directly instead of combining it with the ".." literal. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #5893 Fixes [AB#616797](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/616797) --------- Co-authored-by: Tine Staric <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
microsoft#5837 cannot resolve because of merge conflicts.
We're merging MS BCApps back into this branch in an attempt to resolve those merge conflicts.
Work Item(s)