use CoordinateType #1315
Merged
use CoordinateType #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hjmjohnson
commented
Jan 26, 2025
hjmjohnson
commented
- STYLE: Add itkVirtualGetNameOfClassMacro + itkOverrideGetNameOfClassMacro
- STYLE: Rename ITK_DISALLOW_COPY_AND_ASSIGN to ITK_DISALLOW_COPY_AND_MOVE
- STYLE: CoordRepType -> CoordinateType code readability
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
3424653 to
81dca8c
Compare
Member
|
@hjmjohnson thank you for these patches! In this repository, we use the conventional commit standard for our commit message format in the ITK-Wasm repository, which has tooling and is used across the web development community. This means the commit messages would updated be:
A rebase on |
Member
|
A rebase is necessary to address conflicts and commit messages need to be reformatted per previous comment. |
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
b0be05e to
5389056
Compare
Member
|
A rebase and |
…meOfClassMacro Added two new macro's, intended to replace the old 'itkTypeMacro' and 'itkTypeMacroNoParent'. The main aim is to be clearer about what those macro's do: add a virtual 'GetNameOfClass()' member function and override it. Unlike 'itkTypeMacro', 'itkOverrideGetNameOfClassMacro' does not have a 'superclass' parameter, as it was not used anyway. Note that originally 'itkTypeMacro' did not use its 'superclass' parameter either, looking at commit 699b66cb04d410e555656828e8892107add38ccb, Will Schroeder, June 27, 2001: https://github.com/InsightSoftwareConsortium/ITK/blob/699b66cb04d410e555656828e8892107add38ccb/Code/Common/itkMacro.h#L331-L337
…COPY_AND_MOVE Clarifies that the macro does not just disallow copy and assign, but also move operations. Note that in this context, the term 'move' refers to both move-construct and move-assign. With this commit, the old macro name will remain available, as long as 'ITK_FUTURE_LEGACY_REMOVE = OFF' (which is the default).
For the sake of code readability, a new 'CoordinateType' alias is added for each nested 'CoordRepType' alias. The old 'CoordRepType' aliases will still be available with ITK 6.0, but it is recommended to use 'CoordinateType' instead. The 'CoordRepType' aliases will be removed when 'ITK_FUTURE_LEGACY_REMOVE' is enabled. Similarly, 'InputCoordinateType', 'OutputCoordinateType', and 'ImagePointCoordinateType' replace 'InputCoordRepType', 'OutputCoordRepType', and 'ImagePointCoordRepType', respectively.
Set the default build package tags to v5.4.2 for capturing the ITKRemoteModuleBuildTestPackageAction shared scripts. This pulls the default configuration items needed to build against ITK version v5.4.2.
In preparation for release. Ensure that cmake is 3.16.3 or greater to match v5.4.2 minimum requirements. Set minimum python to 3.9 Increment version number. Replace keyword of "ITK" with lowercase "itk" in some instances to be consistent.
hjmjohnson
force-pushed
the
use-CoordinateType
branch
from
28ed88a to
f88b69a
Compare
Member
Author
|
Fixed commit message prefix. |
Member
|
@hjmjohnson thank you for your hard work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.